LayoutTests/svg/custom/path-domsubtreemodified-crash.html - Issue 62083002: Remove support for the externalResourcesRequired attribute.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/path-domsubtreemodified-crash.html

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/svg/custom/loadevents-normal-displaynone.svg ('k') | LayoutTests/svg/custom/svg-features-expected.txt » ('j') | Source/core/dom/DOMImplementation.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <!-- Test for WK92604 - Passes if no crash occurs and "PASS" is printed. -->	3 <!-- Test for WK92604 - Passes if no crash occurs and "PASS" is printed. -->

4 <body id="body">	4 <body id="body">

5 <svg xmlns="http://www.w3.org/2000/svg">	5 <svg xmlns="http://www.w3.org/2000/svg">

6 <line stroke="green" vector-effect="non-scaling-stroke" y2="1"/>	6 <line stroke="green" vector-effect="non-scaling-stroke" y2="1"/>

7 <defs id="defs"></defs>	7 <defs id="defs"></defs>

8 </svg>	8 </svg>

9 <script>	9 <script>

10 if (window.testRunner) {	10 if (window.testRunner) {

(...skipping 11 matching lines...) Expand all Loading...
22	22

23 document.write("This test passes if no crash occurs and PASS is printed. PASS");	23 document.write("This test passes if no crash occurs and PASS is printed. PASS");

24	24

25 if (window.testRunner)	25 if (window.testRunner)

26 testRunner.notifyDone();	26 testRunner.notifyDone();

27 }, false);	27 }, false);

28	28

29 function doCrash() {	29 function doCrash() {

30 var farthestViewportElement = defs["farthestViewportElement"];	30 var farthestViewportElement = defs["farthestViewportElement"];

31 var externalResourcesRequired = farthestViewportElement["externalResourc esRequired"];	31 var externalResourcesRequired = farthestViewportElement["externalResourc esRequired"];

32 externalResourcesRequired["baseVal"] = undefined;	32 if (externalResourcesRequired)

	33 externalResourcesRequired["baseVal"] = undefined;
	Stephen Chennney 2013/11/06 16:45:43 I think you can remove this test and its result. I I think you can remove this test and its result. I doubt it's still testing what it was testing. Erik Dahlström (inactive) 2013/11/07 09:38:04 fine by me, I was unsure what to do with it since Show quoted text On 2013/11/06 16:45:43, Stephen Chenney wrote: > I think you can remove this test and its result. I doubt it's still testing what > it was testing. fine by me, I was unsure what to do with it since I didn't have access rights to the webkit bug it referred to.
33 body.offsetWidth;	34 body.offsetWidth;

34 body.innerHTML = "FAIL";	35 body.innerHTML = "FAIL";

35 }	36 }

36 </script>	37 </script>

37 </body>	38 </body>

38 </html>	39 </html>

OLD	NEW