Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 620803003: [turbofan] Add control input to Load and LoadElements. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add control input to Load and LoadElements. Also remove the now obsolete ControlEffect operator. TEST=cctest,mjsunit,unittests R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -79 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 7 chunks +12 lines, -18 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-01 10:42:46 UTC) #1
Michael Starzinger
LGTM.
6 years, 2 months ago (2014-10-01 11:03:24 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-10-01 11:08:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698