Source/core/inspector/InspectorDOMAgent.h - Issue 620783002: Devtools Animations: Basic animation inspection & control in Styles pane

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 620783002: Devtools Animations: Basic animation inspection & control in Styles pane (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed sequence number to string id Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorCSSAgent.cpp ('K') | « Source/core/inspector/InspectorCSSAgent.cpp ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | Source/devtools/front_end/elements/AnimationSection.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.h

diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h

index 44a6be98fda4826ed16c486659cdb93acef8d930..68d692a478587f3676329dfcff015535c15a735c 100644

--- a/Source/core/inspector/InspectorDOMAgent.h

+++ b/Source/core/inspector/InspectorDOMAgent.h

@@ -142,6 +142,11 @@ public:

virtual void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;

virtual void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const String* objectId) OVERRIDE;

virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;

+ virtual void getAnimationPlayersForNode(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::AnimationPlayer> >& animationPlayersArray) OVERRIDE;

+ virtual void pauseAnimationPlayer(ErrorString*, const String& id, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;

+ virtual void playAnimationPlayer(ErrorString*, const String& id, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;

+ virtual void setAnimationPlayerCurrentTime(ErrorString*, const String& id, double currentTime, RefPtr<TypeBuilder::DOM::AnimationPlayer>&) OVERRIDE;

+ virtual void getAnimationPlayerState(ErrorString*, const String& id, double* currentTime, bool* isRunning) OVERRIDE;

virtual void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) OVERRIDE;

virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) OVERRIDE;

@@ -213,6 +218,7 @@ public:

Node* assertNode(ErrorString*, int nodeId);

Element* assertElement(ErrorString*, int nodeId);

Document* assertDocument(ErrorString*, int nodeId);

+ AnimationPlayer* assertAnimationPlayer(ErrorString*, String id);

caseq 2014/10/03 12:43:55 nit: const String& id

samli 2014/10/07 05:25:43 Done.

private:

enum SearchMode { NotSearching, SearchingForNormal, SearchingForUAShadow };

@@ -246,6 +252,8 @@ private:

PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForContainerChildren(Node* container, int depth, NodeToIdMap* nodesMap);

PassRefPtr<TypeBuilder::DOM::EventListener> buildObjectForEventListener(const RegisteredEventListener&, const AtomicString& eventType, Node*, const String* objectGroupId);

PassRefPtr<TypeBuilder::Array<TypeBuilder::DOM::Node> > buildArrayForPseudoElements(Element*, NodeToIdMap* nodesMap);

+ PassRefPtr<TypeBuilder::DOM::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&);

+ PassRefPtr<TypeBuilder::DOM::AnimationNode> buildObjectForAnimationNode(AnimationNode&);

Node* nodeForPath(const String& path);

@@ -278,6 +286,7 @@ private:

OwnPtrWillBeMember<DOMEditor> m_domEditor;

bool m_suppressAttributeModifiedEvent;

RawPtrWillBeMember<Listener> m_listener;

+ WillBeHeapHashMap<String, RefPtrWillBeMember<AnimationPlayer> > m_idToAnimationPlayer;

caseq 2014/10/03 12:43:55 When do we release references to AnimationPlayers?

samli 2014/10/07 05:25:43 For now they are cleared on each new node selectio

};