Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 620773003: Rename Int32{UMod,UDiv} to Uint32{Div,Mod} and Int64{UMod,UDiv} to Uint64{Div,Mod}. (Closed)

Created:
6 years, 2 months ago by titzer
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Rename Int32{UMod,UDiv} to Uint32{Div,Mod} and Int64{UMod,UDiv} to Uint64{Div,Mod}. R=bmeurer@chromium.org, mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -93 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 3 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 2 months ago (2014-10-01 09:26:22 UTC) #1
Benedikt Meurer
LGTM
6 years, 2 months ago (2014-10-01 09:27:06 UTC) #2
Michael Starzinger
LGTM <ocd-kickin>sorting looks inconsistent</ocd-kickin>.
6 years, 2 months ago (2014-10-01 09:32:40 UTC) #3
titzer
6 years, 2 months ago (2014-10-01 10:39:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as 24356 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698