Source/core/rendering/RenderMedia.h - Issue 620753006: Rendering API cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMedia.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address jchaffraix remarks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderMedia.h

diff --git a/Source/core/rendering/RenderMedia.h b/Source/core/rendering/RenderMedia.h

index a5cda7b6274bcb36ce0e35af7fb720f5adc8cc97..40e11ab0bb638861aa08c3cab707c63b8a32acef 100644

--- a/Source/core/rendering/RenderMedia.h

+++ b/Source/core/rendering/RenderMedia.h

@@ -38,9 +38,6 @@ public:

virtual ~RenderMedia();

virtual void trace(Visitor*) OVERRIDE;

- RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }

- RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }

Julien - ping for review 2014/10/03 01:26:43 Those are important and should be kept: RenderObje

// If you have a RenderMedia, use firstChild or lastChild instead.

void slowFirstChild() const WTF_DELETED_FUNCTION;

void slowLastChild() const WTF_DELETED_FUNCTION;