Chromium Code Reviews| Index: Source/core/rendering/InlineBox.h |
| diff --git a/Source/core/rendering/InlineBox.h b/Source/core/rendering/InlineBox.h |
| index 9dfe0dd2e1d7b2ddc991d9ec3e4ee3ddf3944003..f3e0b312131d6584b9ff7de2e5f6f95d83fa9e16 100644 |
| --- a/Source/core/rendering/InlineBox.h |
| +++ b/Source/core/rendering/InlineBox.h |
| @@ -204,8 +204,6 @@ public: |
| float width() const { return isHorizontal() ? logicalWidth() : hasVirtualLogicalHeight() ? virtualLogicalHeight() : logicalHeight(); } |
| float height() const { return isHorizontal() ? hasVirtualLogicalHeight() ? virtualLogicalHeight() : logicalHeight() : logicalWidth(); } |
| FloatSize size() const { return FloatSize(width(), height()); } |
| - float right() const { return left() + width(); } |
| - float bottom() const { return top() + height(); } |
|
Julien - ping for review
2014/10/03 01:26:42
I think we should keep these.
|
| // The logicalLeft position is the left edge of the line box in a horizontal line and the top edge in a vertical line. |
| float logicalLeft() const { return isHorizontal() ? m_topLeft.x() : m_topLeft.y(); } |
| @@ -287,7 +285,6 @@ public: |
| } |
| FloatPoint locationIncludingFlipping(); |
| - void flipForWritingMode(FloatRect&); |
|
Julien - ping for review
2014/10/03 01:26:42
This is an inconsistency from my perspective as we
|
| FloatPoint flipForWritingMode(const FloatPoint&); |
| void flipForWritingMode(LayoutRect&); |
| LayoutPoint flipForWritingMode(const LayoutPoint&); |