Rendering API cleanup

Source/core/rendering/InlineBox.h

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 186 matching lines @@
     // y() is the top side of the box in the containing block's coordinate system.
     void setY(float y) { m_topLeft.setY(y); }
     float y() const { return m_topLeft.y(); }
     float top() const { return m_topLeft.y(); }
 
     const FloatPoint& topLeft() const { return m_topLeft; }
 
     float width() const { return isHorizontal() ? logicalWidth() : hasVirtualLogicalHeight() ? virtualLogicalHeight() : logicalHeight(); }
     float height() const { return isHorizontal() ? hasVirtualLogicalHeight() ? virtualLogicalHeight() : logicalHeight() : logicalWidth(); }
     FloatSize size() const { return FloatSize(width(), height()); }
-    float right() const { return left() + width(); }
-    float bottom() const { return top() + height(); }

[Julien - ping for review, 2014/10/03 01:26:42]

I think we should keep these.

 
     // The logicalLeft position is the left edge of the line box in a horizontal line and the top edge in a vertical line.
     float logicalLeft() const { return isHorizontal() ? m_topLeft.x() : m_topLeft.y(); }
     float logicalRight() const { return logicalLeft() + logicalWidth(); }
     void setLogicalLeft(float left)
     {
         if (isHorizontal())
             setX(left);
         else
             setY(left);
@@ skipping 61 matching lines @@
 
     // Use with caution! The type is not checked!
     RenderBoxModelObject* boxModelObject() const
     {
         if (!renderer().isText())
             return toRenderBoxModelObject(&renderer());
         return 0;
     }
 
     FloatPoint locationIncludingFlipping();
-    void flipForWritingMode(FloatRect&);

[Julien - ping for review, 2014/10/03 01:26:42]

This is an inconsistency from my perspective as we have LayoutPoint & FloatPoint
but not FloatRect. We should keep it for consistency.

     FloatPoint flipForWritingMode(const FloatPoint&);
     void flipForWritingMode(LayoutRect&);
     LayoutPoint flipForWritingMode(const LayoutPoint&);
 
     bool knownToHaveNoOverflow() const { return m_bitfields.knownToHaveNoOverflow(); }
     void clearKnownToHaveNoOverflow();
 
     bool dirOverride() const { return m_bitfields.dirOverride(); }
     void setDirOverride(bool dirOverride) { m_bitfields.setDirOverride(dirOverride); }
 
@@ skipping 134 matching lines @@
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::InlineBox*);
 void showLineTree(const blink::InlineBox*);
 #endif
 
 #endif // InlineBox_h