Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index 59741e86d6ce412df91f3a0ee16feb1f80ded73b..7bd6d8ff08e2649e4d8bb2650523ffd244d95a83 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -396,18 +396,6 @@ TransformationMatrix RenderLayer::renderableTransform(PaintBehavior paintBehavio
return *m_transform;
}
-RenderLayer* RenderLayer::enclosingOverflowClipLayer(IncludeSelfOrNot includeSelf) const
-{
- const RenderLayer* layer = (includeSelf == IncludeSelf) ? this : parent();
- while (layer) {
- if (layer->renderer()->hasOverflowClip())
- return const_cast<RenderLayer*>(layer);
-
- layer = layer->parent();
- }
- return 0;
-}
-
static bool checkContainingBlockChainForPagination(RenderLayerModelObject* renderer, RenderBox* ancestorColumnsRenderer)
{
RenderView* view = renderer->view();
@@ -1453,13 +1441,6 @@ void RenderLayer::convertToLayerCoords(const RenderLayer* ancestorLayer, LayoutP
currLayer = accumulateOffsetTowardsAncestor(currLayer, ancestorLayer, location);
}
-void RenderLayer::convertToLayerCoords(const RenderLayer* ancestorLayer, LayoutRect& rect) const
-{
- LayoutPoint delta;
- convertToLayerCoords(ancestorLayer, delta);
- rect.move(-delta.x(), -delta.y());
-}
-
void RenderLayer::didUpdateNeedsCompositedScrolling()
{
updateSelfPaintingLayer();
@@ -3440,22 +3421,6 @@ bool RenderLayer::hasVisibleBoxDecorations() const
return hasBoxDecorationsOrBackground() || hasOverflowControls();
}
-bool RenderLayer::isVisuallyNonEmpty() const
Julien - ping for review 2014/10/02 16:47:49 I swore I had seen a patch use this function, but
-{
- ASSERT(!m_visibleDescendantStatusDirty);
-
- if (hasVisibleContent() && hasNonEmptyChildRenderers())
- return true;
-
- if (renderer()->isReplaced() || renderer()->hasMask())
- return true;
-
- if (hasVisibleBoxDecorations())
- return true;
-
- return false;
-}
-
void RenderLayer::updateFilters(const RenderStyle* oldStyle, const RenderStyle* newStyle)
{
if (!newStyle->hasFilter() && (!oldStyle || !oldStyle->hasFilter()))

Powered by Google App Engine
This is Rietveld 408576698