Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: Source/core/rendering/RenderFlowThread.h

Issue 620753006: Rendering API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderFlowThread.h
diff --git a/Source/core/rendering/RenderFlowThread.h b/Source/core/rendering/RenderFlowThread.h
index effccc8e42f27e7346aa86085043af8868bad57f..2075cce264e886ce317325220af67cd42e91e148 100644
--- a/Source/core/rendering/RenderFlowThread.h
+++ b/Source/core/rendering/RenderFlowThread.h
@@ -143,9 +143,6 @@ protected:
m_endColumnSet = end;
}
- RenderMultiColumnSet* startColumnSet() const { return m_startColumnSet; }
mstensho (USE GERRIT) 2014/10/01 22:21:37 What purpose would this class (RenderMultiColumnSe
- RenderMultiColumnSet* endColumnSet() const { return m_endColumnSet; }
-
private:
RenderMultiColumnSet* m_startColumnSet;
RenderMultiColumnSet* m_endColumnSet;
Julien - ping for review 2014/10/02 16:47:49 Those 2 variables are unused in the code and could
@@ -154,25 +151,6 @@ protected:
typedef PODInterval<LayoutUnit, RenderMultiColumnSet*> MultiColumnSetInterval;
typedef PODIntervalTree<LayoutUnit, RenderMultiColumnSet*> MultiColumnSetIntervalTree;
- class RegionSearchAdapter {
mstensho (USE GERRIT) 2014/10/01 22:21:37 I suggest that you keep this. I'm about to start u
- public:
- RegionSearchAdapter(LayoutUnit offset)
- : m_offset(offset)
- , m_result(0)
- {
- }
-
- const LayoutUnit& lowValue() const { return m_offset; }
- const LayoutUnit& highValue() const { return m_offset; }
- void collectIfNeeded(const MultiColumnSetInterval&);
-
- RenderRegion* result() const { return m_result; }
-
- private:
- LayoutUnit m_offset;
- RenderRegion* m_result;
- };
-
// Stack of objects that pushed a LayoutState object on the RenderView. The
// objects on the stack are the ones that are curently in the process of being
// laid out.

Powered by Google App Engine
This is Rietveld 408576698