Rendering API cleanup

Source/core/rendering/RenderFlowThread.h

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 125 matching lines @@
         {
             setRange(start, end);
         }
 
         void setRange(RenderMultiColumnSet* start, RenderMultiColumnSet* end)
         {
             m_startColumnSet = start;
             m_endColumnSet = end;
         }
 
-        RenderMultiColumnSet* startColumnSet() const { return m_startColumnSet; }

[mstensho (USE GERRIT), 2014/10/01 22:21:37]

What purpose would this class (RenderMultiColumnSetRange) serve without those
methods? I'm pretty sure the right thing to do here is to remove the entire
class.

-        RenderMultiColumnSet* endColumnSet() const { return m_endColumnSet; }
-
     private:
         RenderMultiColumnSet* m_startColumnSet;
         RenderMultiColumnSet* m_endColumnSet;

[Julien - ping for review, 2014/10/02 16:47:49]

Those 2 variables are unused in the code and could be removed.

     };
 
     typedef PODInterval<LayoutUnit, RenderMultiColumnSet*> MultiColumnSetInterval;
     typedef PODIntervalTree<LayoutUnit, RenderMultiColumnSet*> MultiColumnSetIntervalTree;
 
-    class RegionSearchAdapter {

[mstensho (USE GERRIT), 2014/10/01 22:21:37]

I suggest that you keep this. I'm about to start using it again; see
https://codereview.chromium.org/584033002/patch/60001/70176

-    public:
-        RegionSearchAdapter(LayoutUnit offset)
-            : m_offset(offset)
-            , m_result(0)
-        {
-        }
-
-        const LayoutUnit& lowValue() const { return m_offset; }
-        const LayoutUnit& highValue() const { return m_offset; }
-        void collectIfNeeded(const MultiColumnSetInterval&);
-
-        RenderRegion* result() const { return m_result; }
-
-    private:
-        LayoutUnit m_offset;
-        RenderRegion* m_result;
-    };
-
     // Stack of objects that pushed a LayoutState object on the RenderView. The
     // objects on the stack are the ones that are curently in the process of being
     // laid out.
     ListHashSet<const RenderObject*> m_statePusherObjectsStack;
     typedef HashMap<const RenderBox*, LayoutUnit> RenderBoxToOffsetMap;
     RenderBoxToOffsetMap m_boxesToOffsetMap;
 
     MultiColumnSetIntervalTree m_multiColumnSetIntervalTree;
 
     bool m_regionsInvalidated : 1;
@@ skipping 20 matching lines @@
 };
 
 template <> struct ValueToString<RenderMultiColumnSet*> {
     static String string(const RenderMultiColumnSet* value) { return String::format("%p", value); }
 };
 #endif
 
 } // namespace blink
 
 #endif // RenderFlowThread_h