Issue 620663002: MinidumpContext: fix some problems in AMD64 (x86_64) context enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 620663002: MinidumpContext: fix some problems in AMD64 (x86_64) context enums (Closed)

Created:
6 years, 2 months ago by Mark Mentovai

Modified:
6 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

MinidumpContext: fix some problems in AMD64 (x86_64) context enums. This fixes a sloppy compliation error: “Redefinition of enumerator 'kMinidumpContextX86Xstate'”. It also fixes CONTEXT_FULL, which should contain floating-point registers but not segment registers unlike the its 32-bit x86 equivalent. Some comments are revised to provide better, um, context. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5906513e301dc61b9da3a524b067d4ad904cca70

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	minidump/minidump_context.h	View		2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

6 years, 2 months ago (2014-09-30 21:22:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5906513e301dc61b9da3a524b067d4ad904cca70 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages