Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: minidump/minidump_context.h

Issue 620663002: MinidumpContext: fix some problems in AMD64 (x86_64) context enums (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_context.h
diff --git a/minidump/minidump_context.h b/minidump/minidump_context.h
index 0c65216e82da2eeafafc33f84eca76b02b25028b..1c920f4cf73b03915e1dbd81ef62d5674d943a58 100644
--- a/minidump/minidump_context.h
+++ b/minidump/minidump_context.h
@@ -112,11 +112,13 @@ enum MinidumpContextX86Flags : uint32_t {
kMinidumpContextX86Xstate = kMinidumpContextX86 | 0x00000040,
//! \brief Indicates the validity of control, integer, and segment registers.
+ //! (`CONTEXT_FULL`).
kMinidumpContextX86Full = kMinidumpContextX86Control |
kMinidumpContextX86Integer |
kMinidumpContextX86Segment,
//! \brief Indicates the validity of all registers except `xsave` data.
+ //! (`CONTEXT_ALL`).
kMinidumpContextX86All = kMinidumpContextX86Full |
kMinidumpContextX86FloatingPoint |
kMinidumpContextX86Debug |
@@ -217,16 +219,18 @@ enum MinidumpContextAMD64Flags : uint32_t {
//!
//! The context contains `xsave` data. This is used with an extended context
//! structure not currently defined here.
- kMinidumpContextX86Xstate = kMinidumpContextAMD64 | 0x00000040,
+ kMinidumpContextAMD64Xstate = kMinidumpContextAMD64 | 0x00000040,
- //! \brief Indicates the validity of control, integer, and segment registers.
+ //! \brief Indicates the validity of control, integer, and floating-point
+ //! registers (`CONTEXT_FULL`).
kMinidumpContextAMD64Full = kMinidumpContextAMD64Control |
kMinidumpContextAMD64Integer |
- kMinidumpContextAMD64Segment,
+ kMinidumpContextAMD64FloatingPoint,
- //! \brief Indicates the validity of all registers except `xsave` data.
+ //! \brief Indicates the validity of all registers except `xsave` data
+ //! (`CONTEXT_ALL`).
kMinidumpContextAMD64All = kMinidumpContextAMD64Full |
- kMinidumpContextAMD64FloatingPoint |
+ kMinidumpContextAMD64Segment |
kMinidumpContextAMD64Debug,
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698