Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6205007: Merge 74637 - 2010-12-24 Yury Semikhatsky <yurys@chromium.org>... (Closed)

Created:
9 years, 11 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 74637 - 2010-12-24 Yury Semikhatsky <yurys@chromium.org>; Reviewed by Darin Adler. inspector/debugger-step-out.html crashing intermittently in the bots https://bugs.webkit.org/show_bug.cgi?id=50868 Use RefPtr rather instead of raw pointers when keeping references to refcounted objects. * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges): * inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet): TBR=yurys@chromium.org BUG=69296 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -39 lines) Patch
M WebCore/inspector/InspectorCSSAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M WebCore/inspector/InspectorStyleSheet.h View 7 chunks +14 lines, -27 lines 0 comments Download
M WebCore/inspector/InspectorStyleSheet.cpp View 10 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
9 years, 11 months ago (2011-01-12 14:53:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698