Use invalidation sets for :invalid/:valid/:required/:optional.

Use invalidation sets for :invalid/:valid/:required/:optional.

Create invalidation sets for :invalid, :valid, :required, and :optional
pseudo classes and schedule invalidations instead of using
SubtreeStyleChange when those states change.

BUG=419873
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184392

[rune, 2014-10-03 14:08:39]

:valid/:invalid and :optional/:required rely on each other, also for my tests,
so I didn't split it into different CLs.

[rune, 2014-10-06 07:57:37]

rune@opera.com changed reviewers:
+ esprehn@chromium.org

[rune, 2014-10-16 11:18:43]

Rebased.

[rune, 2014-10-20 08:55:03]

rune@opera.com changed reviewers:
+ chrishtr@chromium.org

[rune, 2014-10-24 08:45:13]

ping

[dglazkov, 2014-10-24 17:13:24]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2014-10-24 17:13:25]

lgtm

https://codereview.chromium.org/620333002/diff/20001/Source/core/html/HTMLFor...
File Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/620333002/diff/20001/Source/core/html/HTMLFor...
Source/core/html/HTMLFormElement.cpp:728: // For now unconditionally order style
recalculation, which triggers
Is this comment still valid?

[rune, 2014-10-24 20:12:26]

https://codereview.chromium.org/620333002/diff/20001/Source/core/html/HTMLFor...
File Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/620333002/diff/20001/Source/core/html/HTMLFor...
Source/core/html/HTMLFormElement.cpp:728: // For now unconditionally order style
recalculation, which triggers
On 2014/10/24 17:13:25, dglazkov wrote:
> Is this comment still valid?

Yes. With this CL we still recalculate style without checking validity first. We
just do it for fewer elements.

[rune, 2014-10-24 20:13:27]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-10-24 20:14:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/620333002/20001

[commit-bot: I haz the power, 2014-10-24 20:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:29:24]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/3...)

[rune, 2014-10-24 22:58:03]

rune@opera.com changed reviewers:
+ bartekn@chromium.org

[rune, 2014-10-24 22:58:04]

In the last rebase, I needed to modify the validation update for nested
fieldsets that came from [1]. [1] handled update of valid/invalid state for
fieldsets by doing a SubtreeStyleChange on the outermost fieldset that would
effectively recalculate style for all its descendant fieldsets as well. With
this CL, all fieldsets in the chain, not just the outermost, needs to have an
invalidation set scheduled since they typically just cause a LocalStyleChange.

bartekn@ and/or dglazkov@ should take a look at HTMLFormControlElement.cpp
changes before I take another stab at landing this.

[1] https://codereview.chromium.org/646273004

[esprehn, 2014-10-24 23:07:57]

lgtm

[rune, 2014-10-24 23:11:10]

On 2014/10/24 at 23:07:57, esprehn wrote:
> lgtm

thanks!

[rune, 2014-10-24 23:11:15]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-10-24 23:12:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/620333002/40001

[commit-bot: I haz the power, 2014-10-25 00:32:00]

Committed patchset #3 (id:40001) as 184392

[tkent, 2014-10-27 01:47:18]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2014-10-27 01:47:20]

https://codereview.chromium.org/620333002/diff/40001/Source/core/html/HTMLFor...
File Source/core/html/HTMLFormControlElement.cpp (right):

https://codereview.chromium.org/620333002/diff/40001/Source/core/html/HTMLFor...
Source/core/html/HTMLFormControlElement.cpp:189:
pseudoStateChanged(CSSSelector::PseudoOptional);
Are they enough?  Updating |required| attribute can affect :valid and :invalid
too.

[tkent, 2014-10-27 01:53:05]

https://codereview.chromium.org/620333002/diff/40001/Source/core/html/HTMLFor...
File Source/core/html/HTMLFormControlElement.cpp (right):

https://codereview.chromium.org/620333002/diff/40001/Source/core/html/HTMLFor...
Source/core/html/HTMLFormControlElement.cpp:189:
pseudoStateChanged(CSSSelector::PseudoOptional);
On 2014/10/27 01:47:19, tkent wrote:
> Are they enough?  Updating |required| attribute can affect :valid and :invalid
> too.

Ignore the comment.  We calls setNeedsValidityCheck, and it handles :valid and
:invalid.