Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: Source/core/html/HTMLFieldSetElement.cpp

Issue 620333002: Use invalidation sets for :invalid/:valid/:required/:optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFieldSetElement.cpp
diff --git a/Source/core/html/HTMLFieldSetElement.cpp b/Source/core/html/HTMLFieldSetElement.cpp
index 15824d6b6ba5cc5843fecf3505d548cc9af2487a..95c6b8756b7767276c8226381ee20060b77897a0 100644
--- a/Source/core/html/HTMLFieldSetElement.cpp
+++ b/Source/core/html/HTMLFieldSetElement.cpp
@@ -81,10 +81,8 @@ void HTMLFieldSetElement::setNeedsValidityCheck()
// For now unconditionally order style recalculation, which triggers
// validity recalculation. In the near future, consider implement validity
// cache and recalculate style only if it changed.
- // If setNeedsStyleRecalc ends up being called conditionally here, then
- // the caller will have to call setNeedsValidityCheck for all ancestor
- // fieldsets, not only the furthest one.
- setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Invalid));
+ pseudoStateChanged(CSSSelector::PseudoValid);
+ pseudoStateChanged(CSSSelector::PseudoInvalid);
}
void HTMLFieldSetElement::invalidateDisabledStateUnder(Element& base)

Powered by Google App Engine
This is Rietveld 408576698