Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 620253002: Correctly disable DownloadExtensionTest.DownloadExtensionTest_AcceptDanger on Mac. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correctly disable DownloadExtensionTest.DownloadExtensionTest_AcceptDanger on Mac. The ifdef was reversed. BUG=180759 TBR=yoz@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/30522c0bd0c4d8386fe081ad00f449d563d4a275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
6 years, 2 months ago (2014-10-02 20:53:31 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30522c0bd0c4d8386fe081ad00f449d563d4a275 Cr-Commit-Position: refs/heads/master@{#297899}
6 years, 2 months ago (2014-10-02 20:55:56 UTC) #2
jam
6 years, 2 months ago (2014-10-02 20:56:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30522c0bd0c4d8386fe081ad00f449d563d4a275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698