chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 620253002: Correctly disable DownloadExtensionTest.DownloadExtensionTest_AcceptDanger on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 620253002: Correctly disable DownloadExtensionTest.DownloadExtensionTest_AcceptDanger on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 1ac2b66de9e272f14291e993c1d64840a4f78a34..45e7b49d73b6f10ea38f0bc42c47bc0575de44bb 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -4024,9 +4024,9 @@ void OnDangerPromptCreated(DownloadDangerPrompt* prompt) {

#if defined(OS_MACOSX)

// Flakily triggers and assert on Mac.

// http://crbug.com/180759

-#define MAYBE_DownloadExtensionTest_AcceptDanger DownloadExtensionTest_AcceptDanger

-#else

#define MAYBE_DownloadExtensionTest_AcceptDanger DISABLED_DownloadExtensionTest_AcceptDanger

+#else

+#define MAYBE_DownloadExtensionTest_AcceptDanger DownloadExtensionTest_AcceptDanger

#endif

IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

MAYBE_DownloadExtensionTest_AcceptDanger) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »