Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 620113002: Removed the Isolate* field from literal nodes. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Removed the Isolate* field from literal nodes. Again 50MB less peak memory usage in the bug mentioned below... BUG=417697 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -36 lines) Patch
M src/ast.h View 1 chunk +3 lines, -14 lines 0 comments Download
M src/ast.cc View 1 chunk +13 lines, -14 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast-value-factory.cc View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 2 months ago (2014-10-02 12:59:20 UTC) #2
dcarney
lgtm
6 years, 2 months ago (2014-10-02 13:01:09 UTC) #3
Sven Panne
6 years, 2 months ago (2014-10-02 13:05:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698