Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: src/ast.cc

Issue 620113002: Removed the Isolate* field from literal nodes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/ast-value-factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast.h" 5 #include "src/ast.h"
6 6
7 #include <cmath> // For isfinite. 7 #include <cmath> // For isfinite.
8 #include "src/builtins.h" 8 #include "src/builtins.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/contexts.h" 10 #include "src/contexts.h"
(...skipping 1108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1119 set_dont_crankshaft_reason(kCallToAJavaScriptRuntimeFunction); 1119 set_dont_crankshaft_reason(kCallToAJavaScriptRuntimeFunction);
1120 } 1120 }
1121 } 1121 }
1122 1122
1123 #undef REGULAR_NODE 1123 #undef REGULAR_NODE
1124 #undef DONT_OPTIMIZE_NODE 1124 #undef DONT_OPTIMIZE_NODE
1125 #undef DONT_SELFOPTIMIZE_NODE 1125 #undef DONT_SELFOPTIMIZE_NODE
1126 #undef DONT_CACHE_NODE 1126 #undef DONT_CACHE_NODE
1127 1127
1128 1128
1129 Handle<String> Literal::ToString() { 1129 uint32_t Literal::Hash() {
1130 if (value_->IsString()) return value_->AsString()->string(); 1130 return raw_value()->IsString()
1131 DCHECK(value_->IsNumber()); 1131 ? raw_value()->AsString()->hash()
1132 char arr[100]; 1132 : ComputeLongHash(double_to_uint64(raw_value()->AsNumber()));
1133 Vector<char> buffer(arr, arraysize(arr));
1134 const char* str;
1135 if (value()->IsSmi()) {
1136 // Optimization only, the heap number case would subsume this.
1137 SNPrintF(buffer, "%d", Smi::cast(*value())->value());
1138 str = arr;
1139 } else {
1140 str = DoubleToCString(value()->Number(), buffer);
1141 }
1142 return isolate_->factory()->NewStringFromAsciiChecked(str);
1143 } 1133 }
1144 1134
1145 1135
1136 // static
1137 bool Literal::Match(void* literal1, void* literal2) {
1138 const AstValue* x = static_cast<Literal*>(literal1)->raw_value();
1139 const AstValue* y = static_cast<Literal*>(literal2)->raw_value();
1140 return (x->IsString() && y->IsString() && *x->AsString() == *y->AsString()) ||
1141 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber());
1142 }
1143
1144
1146 } } // namespace v8::internal 1145 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/ast-value-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698