Remove HarfBuzzFaceCoreText

Remove HarfBuzzFaceCoreText

Since the rest of the OS X drawing code moved to FontHarfBuzz
and mostly the Skia based code, we can remove the special cased
metrics callback implementation here.

BUG=419386
R=eae, behdad

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183157

[Dominik Röttsches, 2014-10-01 16:03:25]

Behdad suggests we should keep an eye out on performance regressions, but the
HarfBuzzFaceSkia implemention in my opinion might have better caching.

If this passes the bots, it's ready for review.

[behdad_google, 2014-10-01 16:06:03]

On 2014/10/01 16:03:25, Dominik Röttsches wrote:
> Behdad suggests we should keep an eye out on performance regressions, but the
> HarfBuzzFaceSkia implemention in my opinion might have better caching.

I agree.  The Skia caches seem to work really well.  Just something to keep an
eye on, to make sure the SkiaCoreText stuff is working as expected.

[behdad_google, 2014-10-01 16:06:40]

behdad@google.com changed reviewers:
+ behdad@google.com

[behdad_google, 2014-10-01 16:06:41]

lgtm

[eae, 2014-10-01 16:07:18]

LGTM++

[eae, 2014-10-01 16:07:22]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-10-01 16:07:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619923003/1

[commit-bot: I haz the power, 2014-10-01 20:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 20:30:54]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/25499)

[eae, 2014-10-01 21:21:02]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-10-01 21:22:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619923003/1

[commit-bot: I haz the power, 2014-10-01 22:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 22:55:19]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/25514)

[Dominik Röttsches, 2014-10-02 12:42:15]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-10-02 12:42:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619923003/40001

[Dominik Röttsches, 2014-10-02 12:47:17]

The CQ bit was unchecked by dominik.rottsches@intel.com

[eae, 2014-10-02 18:49:10]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-10-02 18:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619923003/60001

[commit-bot: I haz the power, 2014-10-02 18:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-02 18:50:44]

Failed to apply patch for Source/platform/blink_platform.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/blink_platform.gyp
  Hunk #2 FAILED at 251.
  Hunk #3 succeeded at 261 (offset -1 lines).
  Hunk #4 FAILED at 333.
  Hunk #5 succeeded at 359 (offset -2 lines).
  2 out of 5 hunks FAILED -- saving rejects to file
Source/platform/blink_platform.gyp.rej

Patch:       Source/platform/blink_platform.gyp
Index: Source/platform/blink_platform.gyp
diff --git a/Source/platform/blink_platform.gyp
b/Source/platform/blink_platform.gyp
index
48e15018840e2ae348281e4d4dd23b2d27c57176..8f56adef5adf674aa7ec3710ac2bca0acb90d8f7
100644
--- a/Source/platform/blink_platform.gyp
+++ b/Source/platform/blink_platform.gyp
@@ -235,7 +235,7 @@
     'sources/': [
       # Exclude all platform specific things, reinclude them below on a
per-platform basis
       # FIXME: Figure out how to store these patterns in a variable.
-      ['exclude', '(cf|cg|harfbuzz|mac|opentype|win)/'],
+      ['exclude', '(cf|cg|mac|opentype|win)/'],
       ['exclude', '(?<!Chromium)(CF|CG|Mac|Win)\\.(cpp|mm?)$'],
 
       # *NEON.cpp files need special compile options.
@@ -251,10 +251,6 @@
       ['OS=="linux" or OS=="android" or OS=="win"', {
         'sources/': [
           # Cherry-pick files excluded by the broader regular expressions
above.
-          ['include', 'fonts/harfbuzz/FontHarfBuzz\\.cpp$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzFace\\.(cpp|h)$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzFaceSkia\\.cpp$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzShaper\\.(cpp|h)$'],
           ['include', 'fonts/opentype/OpenTypeTypes\\.h$'],
           ['include', 'fonts/opentype/OpenTypeVerticalData\\.(cpp|h)$'],
           ['include', 'fonts/skia/SimpleFontDataSkia\\.cpp$'],
@@ -262,11 +258,8 @@
         'dependencies': [
           '<(DEPTH)/third_party/harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng',
         ],
-      }, { # OS!="linux" and OS!="android" and OS!="win"
-        'sources/': [
-          ['exclude', 'Harfbuzz[^/]+\\.(cpp|h)$'],
-        ],
-      }],
+      },
+      ],
       ['OS=="linux" or OS=="android"', {
         'sources/': [
           ['include', 'fonts/linux/FontPlatformDataLinux\\.cpp$'],
@@ -336,12 +329,6 @@
 
           ['include', 'fonts/skia/SimpleFontDataSkia\\.cpp$'],
 
-          # Mac uses Harfbuzz.
-          ['include', 'fonts/harfbuzz/FontHarfBuzz\\.cpp$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzFaceCoreText\\.mm$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzFace\\.(cpp|h)$'],
-          ['include', 'fonts/harfbuzz/HarfBuzzShaper\\.(cpp|h)$'],
-
           ['include', 'geometry/mac/FloatPointMac\\.mm$'],
           ['include', 'geometry/mac/FloatRectMac\\.mm$'],
           ['include', 'geometry/mac/FloatSizeMac\\.mm$'],
@@ -364,8 +351,6 @@
           ['exclude', 'geometry/mac/'],
           ['exclude', 'geometry/cg/'],
           ['exclude', 'scroll/ScrollbarThemeMac'],
-
-          ['exclude', 'fonts/harfbuzz/HarfBuzzFaceCoreText\\.cpp$'],
         ],
       }],
       ['OS != "linux" and OS != "mac" and OS != "win"', {

[eae, 2014-10-02 19:01:31]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-10-02 19:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619923003/80001

[commit-bot: I haz the power, 2014-10-02 20:12:13]

Committed patchset #5 (id:80001) as 183157