content/browser/renderer_host/compositor_impl_android.cc - Issue 619843002: cc: Make separate interface for BeginFrame ipc from OutputSurface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 619843002: cc: Make separate interface for BeginFrame ipc from OutputSurface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on master and fix skyostil's comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host_unittest_no_message_loop.cc ('K') | « content/browser/android/in_process/synchronous_compositor_output_surface.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | content/renderer/gpu/compositor_external_begin_frame_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/compositor_impl_android.cc

diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc

index 5d8ecc8138c8406e7e9f8a330afa402dc10b712d..2d7a49b8dcc9609004005d682f299f8d158e54bd 100644

--- a/content/browser/renderer_host/compositor_impl_android.cc

+++ b/content/browser/renderer_host/compositor_impl_android.cc

@@ -27,6 +27,7 @@

#include "cc/output/context_provider.h"

#include "cc/output/output_surface.h"

#include "cc/output/output_surface_client.h"

+#include "cc/scheduler/begin_frame_source.h"

#include "cc/trees/layer_tree_host.h"

#include "content/browser/android/child_process_launcher_android.h"

#include "content/browser/gpu/browser_gpu_channel_host_factory.h"

@@ -405,7 +406,8 @@ void CompositorImpl::SetVisible(bool visible) {

HostSharedBitmapManager::current(),

BrowserGpuMemoryBufferManager::current(),

settings,

- base::MessageLoopProxy::current());

+ base::MessageLoopProxy::current(),

+ nullptr);

host_->SetRootLayer(root_layer_);

host_->SetVisible(true);