cc/trees/layer_tree_host_unittest_no_message_loop.cc - Issue 619843002: cc: Make separate interface for BeginFrame ipc from OutputSurface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_no_message_loop.cc

Issue 619843002: cc: Make separate interface for BeginFrame ipc from OutputSurface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on master and fix skyostil's comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/scheduler/scheduler_unittest.cc ('K') | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | content/renderer/gpu/compositor_external_begin_frame_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/trees/layer_tree_host_unittest_no_message_loop.cc

diff --git a/cc/trees/layer_tree_host_unittest_no_message_loop.cc b/cc/trees/layer_tree_host_unittest_no_message_loop.cc

index aa5a5080928bb483273090c91871a214d77c72bd..78ab0785dcc02d81830e586bee04aedd5cdf2416 100644

--- a/cc/trees/layer_tree_host_unittest_no_message_loop.cc

+++ b/cc/trees/layer_tree_host_unittest_no_message_loop.cc

@@ -13,6 +13,7 @@

#include "cc/output/output_surface.h"

#include "cc/output/output_surface_client.h"

#include "cc/resources/resource_provider.h"

+#include "cc/scheduler/begin_frame_source.h"

#include "cc/test/fake_delegated_renderer_layer.h"

#include "cc/test/test_context_provider.h"

#include "cc/trees/layer_tree_host.h"

@@ -99,7 +100,7 @@ class LayerTreeHostNoMessageLoopTest

LayerTreeSettings settings;

settings.single_thread_proxy_scheduler = false;

layer_tree_host_ = LayerTreeHost::CreateSingleThreaded(

- this, this, NULL, NULL, settings, NULL);

+ this, this, NULL, NULL, settings, NULL, nullptr);

dcheng 2014/11/10 22:56:15 Same comment--seems weird to mix NULL and nullptr

simonhong 2014/11/11 12:54:15 unified to use nullptr.

layer_tree_host_->SetViewportSize(size_);

layer_tree_host_->SetRootLayer(root_layer_);

}