Issue 619783002: V4L2VEA: Expose H264 HW encoding as well, even if VP8 is available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 619783002: V4L2VEA: Expose H264 HW encoding as well, even if VP8 is available (Closed)

Created:
6 years, 2 months ago by hshi1

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

V4L2VEA: Expose H264 HW encoding as well, even if VP8 is available H264 is useful for some users that cannot use VP8. BUG=chromium:414567 TEST=run apprtc and ensure it still uses VP8 where available Review URL: https://codereview.chromium.org/603263004 TBR=posciak@chromium.org Cr-Commit-Position: refs/heads/master@{#297070} (cherry picked from commit 172379d53ad5be5b92d34f179409d50aa9e36630) Committed: https://chromium.googlesource.com/chromium/src/+/921292677ef93355d81efa352499e418515e02d6

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	content/common/gpu/media/v4l2_video_encode_accelerator.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

hshi1

6 years, 2 months ago (2014-09-30 22:27:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
921292677ef93355d81efa352499e418515e02d6 (presubmit successful).

Expand Messages | Collapse Messages