Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Issue 603263004: V4L2VEA: Expose H264 HW encoding as well, even if VP8 is available (Closed)

Created:
6 years, 2 months ago by Pawel Osciak
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

V4L2VEA: Expose H264 HW encoding as well, even if VP8 is available H264 is useful for some users that cannot use VP8. BUG=chromium:414567 TEST=run apprtc and ensure it still uses VP8 where available Committed: https://crrev.com/172379d53ad5be5b92d34f179409d50aa9e36630 Cr-Commit-Position: refs/heads/master@{#297070}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Pawel Osciak
PTAL
6 years, 2 months ago (2014-09-26 11:47:35 UTC) #2
hshi1
LGTM
6 years, 2 months ago (2014-09-26 16:55:21 UTC) #6
scherkus (not reviewing)
lgtm
6 years, 2 months ago (2014-09-26 18:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603263004/60001
6 years, 2 months ago (2014-09-26 23:28:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001) as bfe98373d0ece32f4583010bab004169755e767e
6 years, 2 months ago (2014-09-26 23:35:04 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 23:35:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/172379d53ad5be5b92d34f179409d50aa9e36630
Cr-Commit-Position: refs/heads/master@{#297070}

Powered by Google App Engine
This is Rietveld 408576698