Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 619663002: [turbofan] support all shift operands on ia32 (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] support all shift operands on ia32 R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24387

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-01 10:24:24 UTC) #6
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-01 15:20:45 UTC) #7
dcarney
6 years, 2 months ago (2014-10-02 09:04:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:80001) manually as 24387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698