Source/core/html/HTMLAnchorElement.h - Issue 619613005: The link should be activated by enter key on focusing the child element inside the anchor(relanding)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAnchorElement.h

Issue 619613005: The link should be activated by enter key on focusing the child element inside the anchor(relanding) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/keydown-enter-key-on-focused-element-inside-link-expected.txt ('k') | Source/core/html/HTMLAnchorElement.cpp » ('j') | Source/core/html/HTMLAnchorElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLAnchorElement.h

diff --git a/Source/core/html/HTMLAnchorElement.h b/Source/core/html/HTMLAnchorElement.h

index b88156af79fa4c7f5e3145404113e105cac2ec68..d8ca4d0889cb3459345493270d4bfd21cbf7c12a 100644

--- a/Source/core/html/HTMLAnchorElement.h

+++ b/Source/core/html/HTMLAnchorElement.h

@@ -108,6 +108,7 @@ private:

virtual bool isInteractiveContent() const OVERRIDE FINAL;

virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

void handleClick(Event*);

+ bool isLinkEnterKey(Event*);

uint32_t m_linkRelations;

mutable LinkHash m_cachedVisitedLinkHash;