The link should be activated by enter key on focusing the child element inside the anchor(relanding)

Source/core/html/HTMLAnchorElement.cpp

Index: Source/core/html/HTMLAnchorElement.cpp
diff --git a/Source/core/html/HTMLAnchorElement.cpp b/Source/core/html/HTMLAnchorElement.cpp
index 533dc7f200053467398ad4fcd85b52a2a18c06ed..d7f1711762b111a395563edfb18aa5183ecdc8c8 100644
--- a/Source/core/html/HTMLAnchorElement.cpp
+++ b/Source/core/html/HTMLAnchorElement.cpp
@@ -147,14 +147,14 @@ static void appendServerMapMousePosition(StringBuilder& url, Event* event)
 
 void HTMLAnchorElement::defaultEventHandler(Event* event)
 {
-    if (isLink()) {
-        if (focused() && isEnterKeyKeydownEvent(event) && isLiveLink()) {
+    if (isLiveLink()) {
+        if (isLinkEnterKey(event)) {
             event->setDefaultHandled();
             dispatchSimulatedClick(event);
             return;
         }
 
-        if (isLinkClick(event) && isLiveLink()) {
+        if (isLinkClick(event)) {
             handleClick(event);
             return;
         }
@@ -363,6 +363,24 @@ void HTMLAnchorElement::handleClick(Event* event)
     }
 }
 
+bool HTMLAnchorElement::isLinkEnterKey(Event* event)
+{
+    if (isEnterKeyKeydownEvent(event)) {
+        if (focused())
+            return true;
+
+        ASSERT(event->target());
+        Node* target = event->target()->toNode();
+        ASSERT(target);
+
+        // if the target element is one of form controls or has contentEditable attribute on,
+        // we shouldn't simulate click action
+        if (target->focused() && !((target->isElementNode() && toElement(target)->isFormControlElement()) || target->isContentEditable()))

[robwu, 2014/10/03 13:28:40]

This logic is insufficient, because some form control elements can contain child
elements, and isFormControlElement() does not take the parent nodes into account
(isContentEditable() does look at the parent nodes though).

Here is an example:
<a> href="javascript:alert(0)">
  <button>
    Hello
    <b tabindex="1">
      world
    </b>
  </button>
</a>

Besides that, the Enter key should not be intercepted by every form control
element. For instance, in Firefox, the following code triggers an alert when
Enter is pressed:

<a href="javascript:alert('This is shown in Firefox')">
  <input type=text>
</a>

Track down all relevant defaultEventHandler calls (including non-form elements,
just in case), and check whether its defaultEventHandler implementation is
correct in terms of setting the eventHandled flag.
E.g. HTMLTextAreaElement::defaultEventHandler(Event* event) captures input
events using

    else if (renderer() && event->isBeforeTextInsertedEvent())
        handleBeforeTextInsertedEvent( ... event ... );

but does not call event->setDefaultHandled(true);
Consequently, the event is currently passed up in the DOM tree and ultimately
reaches the <a href> element, which causes a navigation to occur. This could be
fixed using

    else if (renderer() && event->isBeforeTextInsertedEvent()) {
        handleBeforeTextInsertedEvent( ... event ... );
        event->setDefaultHandled(true);
    }

+            return true;
+    }
+    return false;
+}
+
 bool isEnterKeyKeydownEvent(Event* event)
 {
     return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter";