Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 619363002: Don't turn on dither for saveLayers which have no paint (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't turn on dither for saveLayers which have no paint Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining. NOTRY=true Committed: https://skia.googlesource.com/skia/+/4611e7f479b1176a31af0bdc2a12528df5f75167

Patch Set 1 #

Patch Set 2 : Add GM suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
robertphillips
6 years, 2 months ago (2014-10-03 11:59:46 UTC) #2
reed1
lgtm
6 years, 2 months ago (2014-10-03 13:25:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619363002/20001
6 years, 2 months ago (2014-10-03 13:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619363002/20001
6 years, 2 months ago (2014-10-03 13:52:59 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 13:53:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 4611e7f479b1176a31af0bdc2a12528df5f75167

Powered by Google App Engine
This is Rietveld 408576698