Optimize to copy from rotated video to canvas.

Optimize to copy from rotated video to canvas.

Perform this rotation on the canvas, rather than allocating a new bitmap and
copying.

BUG=91208, 47554
Committed: https://crrev.com/bc6e9d5eeef32478690947cb1fdc2e48439acb3d
Cr-Commit-Position: refs/heads/master@{#299094}

[dshwang, 2014-10-02 19:16:03]

dongseong.hwang@intel.com changed reviewers:
+ aelias@chromium.org, rileya@chromium.org, suderman@chromium.org

[dshwang, 2014-10-02 19:16:04]

Could you review? It optimizes suderman's
https://codereview.chromium.org/402133005 CL.
Sorry rileya@ for taking your TODO. I wanna get it done before rebasing
https://codereview.chromium.org/445013002/ to ToT

[dshwang, 2014-10-02 19:17:32]

https://codereview.chromium.org/619343003/diff/1/media/filters/skcanvas_video...
File media/filters/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/619343003/diff/1/media/filters/skcanvas_video...
media/filters/skcanvas_video_renderer.cc:363: canvas->restore();
This code is almost copy&paste from
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/skbitmap_op...

[dshwang, 2014-10-02 19:19:33]

I test it on http://browsertests.herokuapp.com/media/video-canvas/
The video is 180deg rotated, which was downloaded from
https://code.google.com/p/chromium/issues/detail?id=47554#c2

[rileya (GONE FROM CHROMIUM), 2014-10-02 20:16:08]

> Sorry rileya@ for taking your TODO.

Haha, no worries, thanks for tackling this!

lgtm! (non-OWNER)

[rileya (GONE FROM CHROMIUM), 2014-10-02 20:19:41]

Actually, looking at the trybots, I think there may be a bug here. 

Look at:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Blink does translation without knowledge of this rotation metadata (so
width/height may be swapped for 90/270), so I think certain cases where the
drawImage src rect is offset from the origin we might do the wrong thing...
though I would have expected this to have been broken with the old code...

[dshwang, 2014-10-03 12:51:34]

dongseong.hwang@intel.com changed reviewers:
+ scherkus@chromium.org

[dshwang, 2014-10-03 12:52:11]

dongseong.hwang@intel.com changed reviewers:
- scherkus@chromium.org

[dshwang, 2014-10-03 13:04:51]

dongseong.hwang@intel.com changed reviewers:
+ scherkus@chromium.org

[dshwang, 2014-10-03 13:04:53]

On 2014/10/02 20:16:08, rileya wrote:
> > Sorry rileya@ for taking your TODO.
> 
> Haha, no worries, thanks for tackling this!
> 
> lgtm! (non-OWNER)

Thank you for review and kindness :)

scherkus@: Could you review the changes? 


On 2014/10/02 20:19:41, rileya wrote:
> Actually, looking at the trybots, I think there may be a bug here. 

I blindly assumed the src size is always same to the dest size.
Patch Set2 paints |video_frame| on |canvas|, scaling and rotating the result to
fit dimensions specified by |dest_rect|.

> Look at:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Blink does translation without knowledge of this rotation metadata (so
> width/height may be swapped for 90/270), so I think certain cases where the
> drawImage src rect is offset from the origin we might do the wrong thing...
> though I would have expected this to have been broken with the old code...

Blink just says "draw this video frame to dest rect." And SkCanvasVideoRenderer
scales and rotate the video frame to fit dimensions specified by |dest_rect|.

[dshwang, 2014-10-03 14:20:02]

Patchset #2 (id:20001) has been deleted

[dshwang, 2014-10-03 14:34:17]

Patchset #2 (id:40001) has been deleted

[dshwang, 2014-10-09 20:01:02]

scherkus@: Could you review the changes?

[scherkus (not reviewing), 2014-10-09 20:02:28]

lgtm

[dshwang, 2014-10-10 11:01:44]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2014-10-10 11:01:57]

On 2014/10/09 20:02:28, scherkus wrote:
> lgtm

thank you for review!

[commit-bot: I haz the power, 2014-10-10 11:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619343003/80001

[commit-bot: I haz the power, 2014-10-10 11:54:02]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-10-10 11:54:47]

Patchset 3 (id:??) landed as
https://crrev.com/bc6e9d5eeef32478690947cb1fdc2e48439acb3d
Cr-Commit-Position: refs/heads/master@{#299094}