Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402133005: Video Orientation in Canvas (Closed)

Created:
6 years, 5 months ago by suderman
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Added rotation operation to Paint for Canvas/WebGL copying. This corrects for wrong video orientation. BUG=47554 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288518

Patch Set 1 #

Patch Set 2 : Missing parameter in test call to Paint. #

Patch Set 3 : Video Orientation in Canvas #

Patch Set 4 : Test cases #

Total comments: 2

Patch Set 5 : Test cleanup and formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -14 lines) Patch
M cc/resources/video_resource_updater.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 3 chunks +21 lines, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 1 2 3 4 4 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
suderman
aelias@chromium.org: Please review changes in video_resource_update.cc render_widget_host_view_browsertest.cc dalecurtis@chromium.org: Please review changes in webmediaplayer_impl.cc webmediaplayer__ms.cc skcanvas_video_renderer.h ...
6 years, 4 months ago (2014-08-08 20:22:35 UTC) #1
aelias_OOO_until_Jul13
On 2014/08/08 at 20:22:35, suderman wrote: > aelias@chromium.org: Please review changes in > video_resource_update.cc > ...
6 years, 4 months ago (2014-08-08 20:31:03 UTC) #2
DaleCurtis
media/ lgtm % test nit. https://codereview.chromium.org/402133005/diff/60001/media/filters/skcanvas_video_renderer_unittest.cc File media/filters/skcanvas_video_renderer_unittest.cc (right): https://codereview.chromium.org/402133005/diff/60001/media/filters/skcanvas_video_renderer_unittest.cc#newcode193 media/filters/skcanvas_video_renderer_unittest.cc:193: void SkCanvasVideoRendererTest::Paint(VideoFrame* video_frame, Replace ...
6 years, 4 months ago (2014-08-08 20:31:41 UTC) #3
suderman
https://codereview.chromium.org/402133005/diff/60001/media/filters/skcanvas_video_renderer_unittest.cc File media/filters/skcanvas_video_renderer_unittest.cc (right): https://codereview.chromium.org/402133005/diff/60001/media/filters/skcanvas_video_renderer_unittest.cc#newcode193 media/filters/skcanvas_video_renderer_unittest.cc:193: void SkCanvasVideoRendererTest::Paint(VideoFrame* video_frame, On 2014/08/08 20:31:40, DaleCurtis wrote: > ...
6 years, 4 months ago (2014-08-08 20:49:40 UTC) #4
suderman
The CQ bit was checked by suderman@chromium.org
6 years, 4 months ago (2014-08-08 21:23:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suderman@chromium.org/402133005/80001
6 years, 4 months ago (2014-08-08 21:26:09 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:52:42 UTC) #7
Message was sent while issue was closed. 
Change committed as 288518

Powered by Google App Engine
This is Rietveld 408576698