Have V8WorkerGlobalScopeEventListener::callListenerFunction() use V8TRYCATCH_FOR_V8STRINGRESOURCE_R…

Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp

Index: Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
diff --git a/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp b/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
index 5bb0510e7cadb29af3d70c5fa978f6a63b068a91..da79d52d1c8b76b0615114ba08c8a83eed596820 100644
--- a/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
+++ b/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
@@ -91,7 +91,8 @@ v8::Local<v8::Value> V8WorkerGlobalScopeEventListener::callListenerFunction(Exec
         int lineNumber = 1;
         v8::ScriptOrigin origin = handlerFunction->GetScriptOrigin();
         if (!origin.ResourceName().IsEmpty()) {
-            resourceName = toWebCoreString(origin.ResourceName());
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringResourceName, origin.ResourceName(), v8::Local<v8::Value>());

[haraken, 2013/11/15 16:30:00]

ah, I see. In this case we want to return v8::Local<v8::Value>().

[yurys, 2014/04/30 08:46:51]

This change looks wrong to me: if we fail to covert resource name to String here
the code will return and prevent execution of the instrumented functions. The
instrumentation must not affect normal control flow.

Next time you make changes that affect DevTools functionality please make sure
to include people from DevTools team who worked with the code, if you are not
sure who to ask feel free to add pfeldman or myself.

+            resourceName = stringResourceName;
             lineNumber = handlerFunction->GetScriptLineNumber() + 1;
         }
         cookie = InspectorInstrumentation::willCallFunction(context, resourceName, lineNumber);