Have V8WorkerGlobalScopeEventListener::callListenerFunction() use V8TRYCATCH_FOR_V8STRINGRESOURCE_R…

Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 73 matching lines @@
     v8::Local<v8::Object> receiver = getReceiverObject(context, event);
     if (handlerFunction.IsEmpty() || receiver.IsEmpty())
         return v8::Local<v8::Value>();
 
     InspectorInstrumentationCookie cookie;
     if (InspectorInstrumentation::timelineAgentEnabled(context)) {
         String resourceName("undefined");
         int lineNumber = 1;
         v8::ScriptOrigin origin = handlerFunction->GetScriptOrigin();
         if (!origin.ResourceName().IsEmpty()) {
-            resourceName = toWebCoreString(origin.ResourceName());
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringResourceName, origin.ResourceName(), v8::Local<v8::Value>());

[haraken, 2013/11/15 16:30:00]

ah, I see. In this case we want to return v8::Local<v8::Value>().

[yurys, 2014/04/30 08:46:51]

This change looks wrong to me: if we fail to covert resource name to String here
the code will return and prevent execution of the instrumented functions. The
instrumentation must not affect normal control flow.

Next time you make changes that affect DevTools functionality please make sure
to include people from DevTools team who worked with the code, if you are not
sure who to ask feel free to add pfeldman or myself.

+            resourceName = stringResourceName;
             lineNumber = handlerFunction->GetScriptLineNumber() + 1;
         }
         cookie = InspectorInstrumentation::willCallFunction(context, resourceName, lineNumber);
     }
 
     v8::Isolate* isolate = toIsolate(context);
     v8::Handle<v8::Value> parameters[1] = { jsEvent };
     v8::Local<v8::Value> result = V8ScriptRunner::callFunction(handlerFunction, context, receiver, WTF_ARRAY_LENGTH(parameters), parameters, isolate);
 
     InspectorInstrumentation::didCallFunction(cookie);
@@ skipping 10 matching lines @@
 
     EventTarget* target = event->currentTarget();
     v8::Isolate* isolate = toIsolate(context);
     v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate);
     if (value.IsEmpty())
         return v8::Local<v8::Object>();
     return v8::Local<v8::Object>::New(isolate, v8::Handle<v8::Object>::Cast(value));
 }
 
 } // namespace WebCore