Remove chrome://welcome page.

Remove chrome://welcome page.

BUG=388043
TBR=sky@chromium.org

Committed: https://crrev.com/e8da137ee6d1a7744be75763807310344199ec25
Cr-Commit-Position: refs/heads/master@{#297908}

[aurimas (slooooooooow), 2014-10-01 23:58:34]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2014-10-01 23:58:35]

Hey Ted,

PTAL.

Aurimas

[Ted C, 2014-10-02 16:37:02]

On 2014/10/01 23:58:35, aurimas wrote:
> Hey Ted,
> 
> PTAL.
> 
> Aurimas

Need to fix some clang errors.

[aurimas (slooooooooow), 2014-10-02 17:17:49]

On 2014/10/02 16:37:02, Ted C wrote:
> On 2014/10/01 23:58:35, aurimas wrote:
> > Hey Ted,
> > 
> > PTAL.
> > 
> > Aurimas
> 
> Need to fix some clang errors.

clang errors fixed.

[aurimas (slooooooooow), 2014-10-02 17:19:13]

aurimas@chromium.org changed reviewers:
+ dbeam@chromium.org

[aurimas (slooooooooow), 2014-10-02 17:19:13]

dbeam@chromium.org: Please review changes in 
chrome/browser/resources and chrome/browser/ui/webui/

[Ted C, 2014-10-02 17:29:32]

lgtm w/ updating the test

https://chromiumcodereview.appspot.com/619263002/diff/20001/chrome/android/sh...
File
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
(left):

https://chromiumcodereview.appspot.com/619263002/diff/20001/chrome/android/sh...
chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java:37:
@Feature({"Main"})
I think we want to keep some sort of test like this.  It was added in:
https://chromiumcodereview.appspot.com/11823063
and it was meant to check chrome:// page loading.

I think we should rename this to testChromePageLoads and update the url to
something like chrome://flags.  We should then add a comment that the page is
just any supported chrome page and should be updated if this is no longer valid.

[Dan Beam, 2014-10-02 19:22:19]

my face when I saw this CL deleted 400+ lines of code I own:
http://bit.ly/1E5uGUs

lgtm

[aurimas (slooooooooow), 2014-10-02 20:08:09]

aurimas@chromium.org changed reviewers:
+ sky@chromium.org

[aurimas (slooooooooow), 2014-10-02 20:47:19]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-10-02 20:48:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/619263002/80001

[commit-bot: I haz the power, 2014-10-02 21:33:26]

Committed patchset #5 (id:80001) as 494c21e9279b104dc4e976d39657c513c3d96f24

[commit-bot: I haz the power, 2014-10-02 21:33:59]

Patchset 5 (id:??) landed as
https://crrev.com/e8da137ee6d1a7744be75763807310344199ec25
Cr-Commit-Position: refs/heads/master@{#297908}