Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

Issue 619263002: Remove chrome://welcome page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename the test again Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
diff --git a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
index 76a5143918129ce61edb9de2fdd29d92634e3d8a..0932b7b5f3b28e398bdd0d92ba780e7711f4535b 100644
--- a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
+++ b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java
@@ -12,7 +12,6 @@ import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.ContentViewRenderView;
import org.chromium.ui.base.WindowAndroid;
-import java.util.Locale;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
@@ -35,9 +34,10 @@ public class ChromeShellUrlTest extends ChromeShellTestBase {
@SmallTest
@Feature({"Main"})
- public void testChromeWelcomePageLoads() throws InterruptedException {
- String welcomeUrl = "chrome://welcome/";
- final ChromeShellActivity activity = launchChromeShellWithUrl(welcomeUrl);
+ public void testChromeUrlPageLoads() throws InterruptedException {
+ // Test flags page because it will *probably* never get removed.
+ String flagsUrl = "chrome://flags/";
+ final ChromeShellActivity activity = launchChromeShellWithUrl(flagsUrl);
waitForActiveShellToBeDoneLoading();
// Make sure the activity was created as expected.
@@ -56,8 +56,7 @@ public class ChromeShellUrlTest extends ChromeShellTestBase {
assertNotNull(contentViewCore.get().getContainerView());
// Ensure the correct page has been loaded, ie. not interstitial, and title/url should
- // be sane. Note, a typical correct title is: "Welcome to Chromium", whereas a wrong one
- // would be on the form "chrome://welcome/ is not available".
+ // be sane.
final AtomicBoolean isShowingInterstitialPage = new AtomicBoolean();
final AtomicReference<String> url = new AtomicReference<String>();
final AtomicReference<String> title = new AtomicReference<String>();
@@ -73,11 +72,9 @@ public class ChromeShellUrlTest extends ChromeShellTestBase {
assertFalse("Showed interstitial page instead of welcome page",
isShowingInterstitialPage.get());
assertNotNull("URL was null", url.get());
- assertTrue("URL did not contain: " + welcomeUrl + ". Was: " + url.get(),
- url.get().contains(welcomeUrl));
+ assertTrue("URL did not contain: " + flagsUrl + ". Was: " + url.get(),
+ url.get().contains(flagsUrl));
assertNotNull("Title was null", title.get());
- assertFalse("Title should not contain: " + welcomeUrl + ". Was: " + title.get(),
- title.get().toLowerCase(Locale.US).contains(welcomeUrl));
}
/**
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698