Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: ui/views/controls/textfield/native_textfield_views.h

Issue 61923005: Make NativeTextfieldViews update the win system caret. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: const gfx::Rect& Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/win/accessibility_misc_utils.cc ('k') | ui/views/controls/textfield/native_textfield_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/native_textfield_views.h
diff --git a/ui/views/controls/textfield/native_textfield_views.h b/ui/views/controls/textfield/native_textfield_views.h
index aad8dad8275be8faf865437d8e86c8686c5a745f..0870ec2cb50525a83926f5637761780b62e30974 100644
--- a/ui/views/controls/textfield/native_textfield_views.h
+++ b/ui/views/controls/textfield/native_textfield_views.h
@@ -288,6 +288,12 @@ class VIEWS_EXPORT NativeTextfieldViews : public View,
// is -1, existing revealed index will be cleared.
void RevealObscuredChar(int index, const base::TimeDelta& duration);
+ // Platform-specific updating of the system caret location to match ours.
+ void PlatformUpdateSystemCaret();
+
+ // Platform-specific hiding of the system caret whe we lose focus.
+ void PlatformHideSystemCaret();
+
// The parent textfield, the owner of this object.
Textfield* textfield_;
@@ -334,6 +340,9 @@ class VIEWS_EXPORT NativeTextfieldViews : public View,
// and when the time expires, the last typed char is obscured.
base::OneShotTimer<NativeTextfieldViews> obscured_reveal_timer_;
+ // The last caret rect, in screen coordinates.
+ gfx::Rect last_caret_rect_;
+
DISALLOW_COPY_AND_ASSIGN(NativeTextfieldViews);
};
« no previous file with comments | « ui/base/win/accessibility_misc_utils.cc ('k') | ui/views/controls/textfield/native_textfield_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698