Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: include/core/SkFlattenableBuffers.h

Issue 61913002: Adding error checks to SkRBuffer (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Fixed serialization tests Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkBuffer.h » ('j') | src/core/SkPath.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkFlattenableBuffers.h
diff --git a/include/core/SkFlattenableBuffers.h b/include/core/SkFlattenableBuffers.h
index 8a94bb1db252d08d8c319e2705bc2b6bb2918344..8656f2f4974d26d76634a7ae56c0f02ac7a63a5c 100644
--- a/include/core/SkFlattenableBuffers.h
+++ b/include/core/SkFlattenableBuffers.h
@@ -144,7 +144,7 @@ public:
return SkData::NewFromMalloc(buffer, len);
}
- virtual void validate(bool isValid) {}
+ virtual bool validate(bool isValid) { return true; }
reed1 2013/11/08 18:15:39 Lets keep the impls for virtuals in the .cpp
reed1 2013/11/08 18:15:39 I think we need some dox for this guy, now that th
sugoi1 2013/11/08 18:40:56 Done.
sugoi1 2013/11/08 18:40:56 Done.
private:
template <typename T> T* readFlattenableT();
« no previous file with comments | « no previous file | src/core/SkBuffer.h » ('j') | src/core/SkPath.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698