Adding error checks to SkRBuffer

include/core/SkFlattenableBuffers.h

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkFlattenableBuffers_DEFINED
 #define SkFlattenableBuffers_DEFINED
@@ skipping 126 matching lines @@
         return point;
     }
 
     SkData* readByteArrayAsData() {
         size_t len = this->getArrayCount();
         void* buffer = sk_malloc_throw(len);
         (void)this->readByteArray(buffer, len);
         return SkData::NewFromMalloc(buffer, len);
     }
 
-    virtual void validate(bool isValid) {}
+    virtual bool validate(bool isValid) { return true; }

[reed1, 2013/11/08 18:15:39]

Lets keep the impls for virtuals in the .cpp

[reed1, 2013/11/08 18:15:39]

I think we need some dox for this guy, now that there are 4 combinations to
interpret :

true <-- (true)
false <-- (true)
true <-- (false)
false <-- (false)

[sugoi1, 2013/11/08 18:40:56]

Done.

[sugoi1, 2013/11/08 18:40:56]

Done.

 
 private:
     template <typename T> T* readFlattenableT();
     uint32_t fFlags;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 
 class SkFlattenableWriteBuffer {
 public:
@@ skipping 66 matching lines @@
     }
 
 protected:
     // A helper function so that each subclass does not have to be a friend of SkFlattenable
     void flattenObject(const SkFlattenable* obj, SkFlattenableWriteBuffer& buffer);
 
     uint32_t fFlags;
 };
 
 #endif