Issue 618853004: Revert of Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 618853004: Revert of Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as … (Closed)

Created:
6 years, 2 months ago by nasko

Modified:
6 years, 2 months ago

Reviewers:
Krzysztof Olczyk

CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, Mostyn Bramley-Moore, nasko+codewatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as … (patchset #5 id:80001 of https://codereview.chromium.org/298133002/) Reason for revert: This patch broke the memory.fyi bots, as they run tests in single-process mode. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/36766 Original issue's description: > Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as it makes no sense > - we have single process only and no process-separation is expected. > > This allows testing navigation between WebUI and standard pages > in single-process mode. > > BUG= > > Committed: https://crrev.com/bf50b9cc28f7a7749183a6c241c4836d5a66c54c > Cr-Commit-Position: refs/heads/master@{#297683} TBR=kolczyk@opera.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c040f72446a82dd07130ecad0f02a565054c1e72 Cr-Commit-Position: refs/heads/master@{#297705}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -34 lines)			Patch
	M	content/browser/frame_host/render_frame_host_manager.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	content/browser/frame_host/render_frame_host_manager_unittest.cc	View		1 chunk	+0 lines, -31 lines	0 comments	Download

Total messages: 1 (0 generated)

nasko

6 years, 2 months ago (2014-10-01 20:49:10 UTC) #1

Created Revert of Don't ensure, in single-process mode, that WebUI render views
are the only ones in the process, as …