Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(707)

Issue 618723003: Revert of Switch to HarfBuzz on Mac and remove CoreText shaper (Closed)

Created:
5 years, 8 months ago by Zhenyao Mo
Modified:
5 years, 8 months ago
CC:
blink-reviews, Rik, danakj, krit, dsinclair, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Switch to HarfBuzz on Mac and remove CoreText shaper (patchset #29 id:660001 of https://codereview.chromium.org/175253002/) Reason for revert: Caused a bunch layout tests to timeout on mac editing/pasteboard/copy-crash.html fast/events/event-view-toString.html http/tests/navigation/scrollstate-after-http-equiv-refresh.html http/tests/navigation/scrollstate-after-location-reload.html Original issue's description: > Switch to HarfBuzz on Mac and remove CoreText shaper > > Move to HarfBuzz for shaping on mac and remove the old mac-specific > CoreText shaper Test case added based on handmade ChromiumAATTest font > for verifying AAT shaping is functional. > > TEST=fast/text/aat-morx.html > BUG=334269 > NOTRY=true > R=eae@chromium.org, esprehn@chromium.org, behdad@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182920 TBR=esprehn@chromium.org,abarth@chromium.org,behdad@chromium.org,dglazkov@chromium.org,eae@chromium.org,jshin@chromium.org,tkent@chromium.org,dominik.rottsches@intel.com NOTREECHECKS=true NOTRY=true BUG=334269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2398 lines, -7778 lines) Patch
M LayoutTests/NeverFixTests View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/TestExpectations View 11 chunks +41 lines, -7514 lines 0 comments Download
D LayoutTests/fast/text/aat-morx.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/aat-morx-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/aat-morx-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/build/features.gypi View 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gyp View 2 chunks +4 lines, -9 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +8 lines, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 3 chunks +29 lines, -32 lines 0 comments Download
M Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm View 3 chunks +15 lines, -27 lines 0 comments Download
A Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.cpp View 1 chunk +146 lines, -0 lines 0 comments Download
D Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.mm View 1 chunk +0 lines, -161 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/fonts/mac/ComplexTextController.h View 1 chunk +180 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/ComplexTextController.cpp View 1 chunk +614 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/ComplexTextControllerCoreText.mm View 1 chunk +297 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/FontComplexTextMac.cpp View 1 chunk +209 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/FontMac.cpp View 1 chunk +182 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/SimpleFontDataCoreText.cpp View 1 chunk +201 lines, -0 lines 0 comments Download
A Source/platform/fonts/mac/SimpleFontDataMac.mm View 1 chunk +454 lines, -0 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Zhenyao Mo
Created Revert of Switch to HarfBuzz on Mac and remove CoreText shaper
5 years, 8 months ago (2014-09-30 17:39:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618723003/1
5 years, 8 months ago (2014-09-30 17:40:39 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 8 months ago (2014-09-30 17:41:14 UTC) #4
d.roettsches
Could you suspend committing this, and add the timeouts to the bug that I mentioned ...
5 years, 8 months ago (2014-09-30 17:43:50 UTC) #5
Dominik Röttsches
5 years, 8 months ago (2014-10-01 07:31:40 UTC) #6
We can probably close this one.

Powered by Google App Engine
This is Rietveld 408576698