Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 618703002: Fix svn tags in release scripts. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix svn tags in release scripts. Rebase the local branch after committing so that git svn tag works. Some of these changes need to be ported to git in https://codereview.chromium.org/607893004/ BUG=chromium:410721, v8:3601 LOG=n TEST=script_test.py R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24330

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M tools/push-to-trunk/auto_tag.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/push-to-trunk/common_includes.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 2 3 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL
6 years, 2 months ago (2014-09-30 12:51:17 UTC) #2
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-09-30 12:55:13 UTC) #3
Michael Achenbach
6 years, 2 months ago (2014-09-30 13:12:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698