Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/push-to-trunk/common_includes.py

Issue 618703002: Fix svn tags in release scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/push-to-trunk/auto_tag.py ('k') | tools/push-to-trunk/merge_to_branch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py b/tools/push-to-trunk/common_includes.py
index 7ea39f73c95e80c86e10eb960241dc3e7683b76d..f015601a070b652b816dfe5e9e0f6814306a0cc6 100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -295,7 +295,7 @@ class VCInterface(object):
# TODO(machenbach): There is some svn knowledge in this interface. In svn,
# tag and commit are different remote commands, while in git we would commit
# and tag locally and then push/land in one unique step.
- def Tag(self, tag):
+ def Tag(self, tag, remote):
raise NotImplementedError()
@@ -342,7 +342,9 @@ class GitSvnInterface(VCInterface):
def CLLand(self):
self.step.GitDCommit()
- def Tag(self, tag):
+ def Tag(self, tag, remote):
+ self.step.GitSVNFetch()
+ self.step.Git("rebase %s" % remote)
self.step.GitSVNTag(tag)
« no previous file with comments | « tools/push-to-trunk/auto_tag.py ('k') | tools/push-to-trunk/merge_to_branch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698