Source/core/loader/ThreadableLoaderClient.h - Issue 618583002: Correct data size argument type in resource loading path to unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/ThreadableLoaderClient.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/ThreadableLoaderClient.h

diff --git a/Source/core/loader/ThreadableLoaderClient.h b/Source/core/loader/ThreadableLoaderClient.h

index 3895fb4114045c7f217e0b996a0e2dde271a4003..8a7e42c9f18803a14c21599d153ef01e22df9eb4 100644

--- a/Source/core/loader/ThreadableLoaderClient.h

+++ b/Source/core/loader/ThreadableLoaderClient.h

@@ -47,7 +47,7 @@ namespace blink {

virtual void didSendData(unsigned long long /*bytesSent*/, unsigned long long /*totalBytesToBeSent*/) { }

virtual void didReceiveResponse(unsigned long /*identifier*/, const ResourceResponse&) { }

- virtual void didReceiveData(const char*, int /*dataLength*/) { }

+ virtual void didReceiveData(const char*, unsigned /*dataLength*/) { }

virtual void didReceiveCachedMetadata(const char*, int /*dataLength*/) { }

virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/) { }

virtual void didFail(const ResourceError&) { }

« no previous file with comments | « Source/core/loader/TextTrackLoader.cpp ('k') | Source/core/loader/ThreadableLoaderClientWrapper.h » ('j') | no next file with comments »