Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/core/loader/ThreadableLoaderClient.h

Issue 618583002: Correct data size argument type in resource loading path to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add static_cast to RELEASE_ASSERT in AssociatedURLLoader::ClientAdapter::didReceiveData Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 class ResourceError; 40 class ResourceError;
41 class ResourceResponse; 41 class ResourceResponse;
42 42
43 class ThreadableLoaderClient { 43 class ThreadableLoaderClient {
44 WTF_MAKE_NONCOPYABLE(ThreadableLoaderClient); 44 WTF_MAKE_NONCOPYABLE(ThreadableLoaderClient);
45 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED; 45 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
46 public: 46 public:
47 virtual void didSendData(unsigned long long /*bytesSent*/, unsigned long long /*totalBytesToBeSent*/) { } 47 virtual void didSendData(unsigned long long /*bytesSent*/, unsigned long long /*totalBytesToBeSent*/) { }
48 48
49 virtual void didReceiveResponse(unsigned long /*identifier*/, const Reso urceResponse&) { } 49 virtual void didReceiveResponse(unsigned long /*identifier*/, const Reso urceResponse&) { }
50 virtual void didReceiveData(const char*, int /*dataLength*/) { } 50 virtual void didReceiveData(const char*, unsigned /*dataLength*/) { }
51 virtual void didReceiveCachedMetadata(const char*, int /*dataLength*/) { } 51 virtual void didReceiveCachedMetadata(const char*, int /*dataLength*/) { }
52 virtual void didFinishLoading(unsigned long /*identifier*/, double /*fin ishTime*/) { } 52 virtual void didFinishLoading(unsigned long /*identifier*/, double /*fin ishTime*/) { }
53 virtual void didFail(const ResourceError&) { } 53 virtual void didFail(const ResourceError&) { }
54 virtual void didFailAccessControlCheck(const ResourceError& error) { did Fail(error); } 54 virtual void didFailAccessControlCheck(const ResourceError& error) { did Fail(error); }
55 virtual void didFailRedirectCheck() { } 55 virtual void didFailRedirectCheck() { }
56 56
57 virtual bool isDocumentThreadableLoaderClient() { return false; } 57 virtual bool isDocumentThreadableLoaderClient() { return false; }
58 58
59 virtual void didDownloadData(int /*dataLength*/) { } 59 virtual void didDownloadData(int /*dataLength*/) { }
60 60
61 virtual ~ThreadableLoaderClient() { } 61 virtual ~ThreadableLoaderClient() { }
62 62
63 protected: 63 protected:
64 ThreadableLoaderClient() { } 64 ThreadableLoaderClient() { }
65 }; 65 };
66 66
67 } // namespace blink 67 } // namespace blink
68 68
69 #endif // ThreadableLoaderClient_h 69 #endif // ThreadableLoaderClient_h
OLDNEW
« no previous file with comments | « Source/core/loader/TextTrackLoader.cpp ('k') | Source/core/loader/ThreadableLoaderClientWrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698