Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 618413002: Check for NULL NativeView in linux/mac Screen::GetDisplayNearestWindow(). (Closed)

Created:
6 years, 2 months ago by lazyboy
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check for NULL NativeView in linux/mac Screen::GetDisplayNearestWindow(). This is similar to what ScreenAsh::GetDisplayNearestWindow() is doing. There can be cases when NativeView is NULL. BUG=419611 Test=See bug description. Committed: https://crrev.com/7b68c34c60f3f4b26245bc74ff6f4376699ef8cc Cr-Commit-Position: refs/heads/master@{#297883}

Patch Set 1 #

Patch Set 2 : add comment to screen.h #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/gfx/screen.h View 1 1 chunk +2 lines, -0 lines 1 comment Download
M ui/gfx/screen_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
lazyboy
Hi Scott, This CL is not necessary to fix http://crbug.com/419611, but I felt this would ...
6 years, 2 months ago (2014-10-02 03:37:22 UTC) #2
sky
I think this is ok, but you should clear up in screen.h what NULL means.
6 years, 2 months ago (2014-10-02 15:56:17 UTC) #3
lazyboy
https://chromiumcodereview.appspot.com/618413002/diff/20001/ui/gfx/screen.h File ui/gfx/screen.h (right): https://chromiumcodereview.appspot.com/618413002/diff/20001/ui/gfx/screen.h#newcode74 ui/gfx/screen.h:74: // If the window is NULL or the window ...
6 years, 2 months ago (2014-10-02 16:16:21 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-02 17:23:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618413002/20001
6 years, 2 months ago (2014-10-02 19:45:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 01112f6811d23cbfb5398309290d26bd5593d0d3
6 years, 2 months ago (2014-10-02 19:51:29 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:52:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b68c34c60f3f4b26245bc74ff6f4376699ef8cc
Cr-Commit-Position: refs/heads/master@{#297883}

Powered by Google App Engine
This is Rietveld 408576698