ui/gfx/screen.h - Issue 618413002: Check for NULL NativeView in linux/mac Screen::GetDisplayNearestWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/screen.h

Issue 618413002: Check for NULL NativeView in linux/mac Screen::GetDisplayNearestWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment to screen.h Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/screen.h

diff --git a/ui/gfx/screen.h b/ui/gfx/screen.h

index 1d36d1b51cbefb9bff481219a7bddb6596b6875c..e6a38a6fdc72cef1d5911545e08fb6be4b1dfdbd 100644

--- a/ui/gfx/screen.h

+++ b/ui/gfx/screen.h

@@ -71,6 +71,8 @@ class GFX_EXPORT Screen {

virtual std::vector<gfx::Display> GetAllDisplays() const = 0;

// Returns the display nearest the specified window.

+ // If the window is NULL or the window is not rooted to a display this will

lazyboy 2014/10/02 16:16:21 I've added this comment, if that's what you meant.

+ // return the primary display.

virtual gfx::Display GetDisplayNearestWindow(NativeView view) const = 0;

// Returns the display nearest the specified point.

« no previous file with comments | « no previous file | ui/gfx/screen_mac.mm » ('j') | no next file with comments »