Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: Source/platform/fonts/Character.cpp

Issue 618383003: Remove obsolete canExpandAroundIdeographsInComplexText (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/Font.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/Character.cpp
diff --git a/Source/platform/fonts/Character.cpp b/Source/platform/fonts/Character.cpp
index 9da5c8dfcc3978acfb59c759550aed91ee2e6b34..b8a49745ba0a4d112999e911c8f91b9aa221879b 100644
--- a/Source/platform/fonts/Character.cpp
+++ b/Source/platform/fonts/Character.cpp
@@ -31,7 +31,6 @@
#include "config.h"
#include "platform/fonts/Character.h"
-#include "platform/fonts/FontPlatformFeatures.h"
#include "wtf/StdLibExtras.h"
#include "wtf/text/StringBuilder.h"
@@ -288,7 +287,6 @@ unsigned Character::expansionOpportunityCount(const LChar* characters, size_t le
unsigned Character::expansionOpportunityCount(const UChar* characters, size_t length, TextDirection direction, bool& isAfterExpansion)
{
- static bool expandAroundIdeographs = FontPlatformFeatures::canExpandAroundIdeographsInComplexText();
unsigned count = 0;
if (direction == LTR) {
for (size_t i = 0; i < length; ++i) {
@@ -302,13 +300,6 @@ unsigned Character::expansionOpportunityCount(const UChar* characters, size_t le
character = U16_GET_SUPPLEMENTARY(character, characters[i + 1]);
i++;
}
- if (expandAroundIdeographs && isCJKIdeographOrSymbol(character)) {
- if (!isAfterExpansion)
- count++;
- count++;
- isAfterExpansion = true;
- continue;
- }
isAfterExpansion = false;
}
} else {
@@ -323,13 +314,6 @@ unsigned Character::expansionOpportunityCount(const UChar* characters, size_t le
character = U16_GET_SUPPLEMENTARY(characters[i - 2], character);
i--;
}
- if (expandAroundIdeographs && isCJKIdeographOrSymbol(character)) {
- if (!isAfterExpansion)
- count++;
- count++;
- isAfterExpansion = true;
- continue;
- }
isAfterExpansion = false;
}
}
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/Font.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698