[bindings] partial interfaces should not violate componentization

Source/core/core.gypi

Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index d23b07445817a6ad4994389dc6f7861c45fab905..069b9c91290e725190229d854b44802aa93dea36 100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -12,7 +12,6 @@
             'animation/AnimationTimeline.idl',
             'animation/Timing.idl',
             'clipboard/DataTransfer.idl',
-            'clipboard/DataTransferItem.idl',
             'clipboard/DataTransferItemList.idl',
             'css/CSS.idl',
             'css/CSSCharsetRule.idl',
@@ -91,7 +90,6 @@
             'dom/Touch.idl',
             'dom/TouchList.idl',
             'dom/TreeWalker.idl',
-            'dom/URL.idl',
             'dom/XMLDocument.idl',
             'dom/shadow/ShadowRoot.idl',
             'editing/Selection.idl',
@@ -135,9 +133,6 @@
             'frame/History.idl',
             'frame/ImageBitmap.idl',
             'frame/Location.idl',
-            'frame/Navigator.idl',
-            'frame/Screen.idl',
-            'frame/Window.idl',
             'html/FormData.idl',
             'html/HTMLAllCollection.idl',
             'html/HTMLAnchorElement.idl',
@@ -172,7 +167,6 @@
             'html/HTMLHtmlElement.idl',
             'html/HTMLIFrameElement.idl',
             'html/HTMLImageElement.idl',
-            'html/HTMLInputElement.idl',
             'html/HTMLKeygenElement.idl',
             'html/HTMLLIElement.idl',
             'html/HTMLLabelElement.idl',
@@ -180,7 +174,6 @@
             'html/HTMLLinkElement.idl',
             'html/HTMLMapElement.idl',
             'html/HTMLMarqueeElement.idl',
-            'html/HTMLMediaElement.idl',
             'html/HTMLMenuElement.idl',
             'html/HTMLMenuItemElement.idl',
             'html/HTMLMetaElement.idl',
@@ -216,7 +209,6 @@
             'html/HTMLTrackElement.idl',
             'html/HTMLUListElement.idl',
             'html/HTMLUnknownElement.idl',
-            'html/HTMLVideoElement.idl',
             'html/ImageData.idl',
             'html/MediaController.idl',
             'html/MediaError.idl',
@@ -281,7 +273,6 @@
             'html/track/vtt/VTTRegion.idl',
             'html/track/vtt/VTTRegionList.idl',
             'inspector/InjectedScriptHost.idl',
-            'inspector/InspectorFrontendHost.idl',
             'inspector/InspectorOverlayHost.idl',
             'inspector/JavaScriptCallFrame.idl',
             'loader/appcache/ApplicationCache.idl',
@@ -440,14 +431,9 @@
             'timing/PerformanceNavigation.idl',
             'timing/PerformanceResourceTiming.idl',
             'timing/PerformanceTiming.idl',
-            'workers/DedicatedWorkerGlobalScope.idl',
-            'workers/SharedWorker.idl',
-            'workers/SharedWorkerGlobalScope.idl',
             'workers/Worker.idl',
             'workers/WorkerConsole.idl',
-            'workers/WorkerGlobalScope.idl',
             'workers/WorkerLocation.idl',
-            'workers/WorkerNavigator.idl',
             'xml/DOMParser.idl',
             'xml/XMLHttpRequest.idl',
             'xml/XMLHttpRequestEventTarget.idl',
@@ -460,6 +446,23 @@
             'xml/XPathResult.idl',
             'xml/XSLTProcessor.idl',
         ],
+        # core defines, and modules updates with 'partial interface'

[haraken, 2014/10/09 04:24:02]

# core IDL files that have partial interfaces in modules.

[tasak, 2014/10/10 07:52:24]

Done.

+        'core_modules_dependency_idl_files': [

[haraken, 2014/10/09 04:24:02]

core_idl_files_with_modules_dependency ?

What happens if we write "an IDL file that should be in
core_idl_files_with_modules_dependency" in core_idl_files? Will it lead to a
compile error?

I'm fine with the approach of statically listing IDL files in GYP files, but we
should have a way to detect an error if a developer writes an IDL file in a
wrong target.

[tasak, 2014/10/10 07:52:24]

If we add an idl file with modules dependency to code_idl_files, we will see no
compile error and will see layout test regression (e.g. undefined XXX).

I think, presubmit check or bindings tests will help us to detect such errors.

[haraken, 2014/10/16 04:24:07]

I think we need to have a verification for this. Probably the IDL compiler can
do the verification because the IDL compiler knows what interface is depended by
what interfaces. You can do it in a follow-up.

+            'clipboard/DataTransferItem.idl',
+            'dom/URL.idl',
+            'frame/Navigator.idl',
+            'frame/Screen.idl',
+            'frame/Window.idl',
+            'html/HTMLInputElement.idl',
+            'html/HTMLMediaElement.idl',
+            'html/HTMLVideoElement.idl',
+            'inspector/InspectorFrontendHost.idl',
+            'workers/DedicatedWorkerGlobalScope.idl',
+            'workers/SharedWorker.idl',
+            'workers/SharedWorkerGlobalScope.idl',
+            'workers/WorkerGlobalScope.idl',
+            'workers/WorkerNavigator.idl',
+        ],
         # 'partial interface', target (right side of) 'implements', and
         # interfaces with static bindings (in bindings/core/v8/)
         'core_dependency_idl_files': [
@@ -3436,13 +3439,16 @@
           'testing/GCObservation.idl',
           'testing/InternalProfilers.idl',
           'testing/InternalSettings.idl',
-          'testing/Internals.idl',
           'testing/LayerRect.idl',
           'testing/LayerRectList.idl',
           'testing/PrivateScriptTest.idl',
           'testing/RefCountedScriptWrappable.idl',
           'testing/TypeConversions.idl',
         ],
+        # core defines, and modules updates with 'partial interface'

[haraken, 2014/10/09 04:24:02]

# testing IDL files that have partial interfaces in modules.

[tasak, 2014/10/10 07:52:24]

Done.

+        'webcore_testing_modules_dependency_idl_files': [
+          'testing/Internals.idl',
+        ],
         'webcore_testing_dependency_idl_files': [
           'testing/PartialPrivateScriptTest.idl',
         ],