[bindings] partial interfaces should not violate componentization

Source/core/core.gypi

 {
     'includes': [
       'core_generated.gypi',
     ],
     'variables': {
         # Files for which bindings (.cpp and .h files) will be generated
         'core_idl_files': [
             'animation/Animation.idl',
             'animation/AnimationEffect.idl',
             'animation/AnimationPlayer.idl',
             'animation/AnimationNode.idl',
             'animation/AnimationTimeline.idl',
             'animation/Timing.idl',
             'clipboard/DataTransfer.idl',
-            'clipboard/DataTransferItem.idl',
             'clipboard/DataTransferItemList.idl',
             'css/CSS.idl',
             'css/CSSCharsetRule.idl',
             'css/CSSFontFaceRule.idl',
             'css/CSSImportRule.idl',
             'css/CSSKeyframeRule.idl',
             'css/CSSKeyframesRule.idl',
             'css/CSSMediaRule.idl',
             'css/CSSPageRule.idl',
             'css/CSSPrimitiveValue.idl',
@@ skipping 58 matching lines @@
             'dom/NodeIterator.idl',
             'dom/NodeList.idl',
             'dom/ProcessingInstruction.idl',
             'dom/Range.idl',
             'dom/RequestAnimationFrameCallback.idl',
             'dom/StringCallback.idl',
             'dom/Text.idl',
             'dom/Touch.idl',
             'dom/TouchList.idl',
             'dom/TreeWalker.idl',
-            'dom/URL.idl',
             'dom/XMLDocument.idl',
             'dom/shadow/ShadowRoot.idl',
             'editing/Selection.idl',
             'events/AnimationPlayerEvent.idl',
             'events/ApplicationCacheErrorEvent.idl',
             'events/AutocompleteErrorEvent.idl',
             'events/BeforeUnloadEvent.idl',
             'events/CompositionEvent.idl',
             'events/CustomEvent.idl',
             'events/ErrorEvent.idl',
@@ skipping 23 matching lines @@
             'fileapi/FileError.idl',
             'fileapi/FileList.idl',
             'fileapi/FileReader.idl',
             'fileapi/FileReaderSync.idl',
             'frame/BarProp.idl',
             'frame/Console.idl',
             'frame/ConsoleBase.idl',
             'frame/History.idl',
             'frame/ImageBitmap.idl',
             'frame/Location.idl',
-            'frame/Navigator.idl',
-            'frame/Screen.idl',
-            'frame/Window.idl',
             'html/FormData.idl',
             'html/HTMLAllCollection.idl',
             'html/HTMLAnchorElement.idl',
             'html/HTMLAppletElement.idl',
             'html/HTMLAreaElement.idl',
             'html/HTMLAudioElement.idl',
             'html/HTMLBRElement.idl',
             'html/HTMLBaseElement.idl',
             'html/HTMLBodyElement.idl',
             'html/HTMLButtonElement.idl',
@@ skipping 14 matching lines @@
             'html/HTMLFormControlsCollection.idl',
             'html/HTMLFormElement.idl',
             'html/HTMLFrameElement.idl',
             'html/HTMLFrameSetElement.idl',
             'html/HTMLHRElement.idl',
             'html/HTMLHeadElement.idl',
             'html/HTMLHeadingElement.idl',
             'html/HTMLHtmlElement.idl',
             'html/HTMLIFrameElement.idl',
             'html/HTMLImageElement.idl',
-            'html/HTMLInputElement.idl',
             'html/HTMLKeygenElement.idl',
             'html/HTMLLIElement.idl',
             'html/HTMLLabelElement.idl',
             'html/HTMLLegendElement.idl',
             'html/HTMLLinkElement.idl',
             'html/HTMLMapElement.idl',
             'html/HTMLMarqueeElement.idl',
-            'html/HTMLMediaElement.idl',
             'html/HTMLMenuElement.idl',
             'html/HTMLMenuItemElement.idl',
             'html/HTMLMetaElement.idl',
             'html/HTMLMeterElement.idl',
             'html/HTMLModElement.idl',
             'html/HTMLOListElement.idl',
             'html/HTMLObjectElement.idl',
             'html/HTMLOptGroupElement.idl',
             'html/HTMLOptionElement.idl',
             'html/HTMLOptionsCollection.idl',
@@ skipping 15 matching lines @@
             'html/HTMLTableColElement.idl',
             'html/HTMLTableElement.idl',
             'html/HTMLTableRowElement.idl',
             'html/HTMLTableSectionElement.idl',
             'html/HTMLTemplateElement.idl',
             'html/HTMLTextAreaElement.idl',
             'html/HTMLTitleElement.idl',
             'html/HTMLTrackElement.idl',
             'html/HTMLUListElement.idl',
             'html/HTMLUnknownElement.idl',
-            'html/HTMLVideoElement.idl',
             'html/ImageData.idl',
             'html/MediaController.idl',
             'html/MediaError.idl',
             'html/MediaKeyError.idl',
             'html/MediaKeyEvent.idl',
             'html/RadioNodeList.idl',
             'html/TextMetrics.idl',
             'html/TimeRanges.idl',
             'html/ValidityState.idl',
             'html/VoidCallback.idl',
@@ skipping 44 matching lines @@
             'html/track/TextTrackCue.idl',
             'html/track/TextTrackCueList.idl',
             'html/track/TextTrackList.idl',
             'html/track/TrackEvent.idl',
             'html/track/VideoTrack.idl',
             'html/track/VideoTrackList.idl',
             'html/track/vtt/VTTCue.idl',
             'html/track/vtt/VTTRegion.idl',
             'html/track/vtt/VTTRegionList.idl',
             'inspector/InjectedScriptHost.idl',
-            'inspector/InspectorFrontendHost.idl',
             'inspector/InspectorOverlayHost.idl',
             'inspector/JavaScriptCallFrame.idl',
             'loader/appcache/ApplicationCache.idl',
             'page/EventSource.idl',
             'page/PagePopupController.idl',
             'plugins/MimeType.idl',
             'plugins/MimeTypeArray.idl',
             'plugins/Plugin.idl',
             'plugins/PluginArray.idl',
             'storage/Storage.idl',
@@ skipping 138 matching lines @@
             'svg/SVGViewSpec.idl',
             'svg/SVGZoomEvent.idl',
             'timing/MemoryInfo.idl',
             'timing/Performance.idl',
             'timing/PerformanceEntry.idl',
             'timing/PerformanceMark.idl',
             'timing/PerformanceMeasure.idl',
             'timing/PerformanceNavigation.idl',
             'timing/PerformanceResourceTiming.idl',
             'timing/PerformanceTiming.idl',
-            'workers/DedicatedWorkerGlobalScope.idl',
-            'workers/SharedWorker.idl',
-            'workers/SharedWorkerGlobalScope.idl',
             'workers/Worker.idl',
             'workers/WorkerConsole.idl',
-            'workers/WorkerGlobalScope.idl',
             'workers/WorkerLocation.idl',
-            'workers/WorkerNavigator.idl',
             'xml/DOMParser.idl',
             'xml/XMLHttpRequest.idl',
             'xml/XMLHttpRequestEventTarget.idl',
             'xml/XMLHttpRequestProgressEvent.idl',
             'xml/XMLHttpRequestUpload.idl',
             'xml/XMLSerializer.idl',
             'xml/XPathEvaluator.idl',
             'xml/XPathExpression.idl',
             'xml/XPathNSResolver.idl',
             'xml/XPathResult.idl',
             'xml/XSLTProcessor.idl',
         ],
+        # core defines, and modules updates with 'partial interface'

[haraken, 2014/10/09 04:24:02]

# core IDL files that have partial interfaces in modules.

[tasak, 2014/10/10 07:52:24]

Done.

+        'core_modules_dependency_idl_files': [

[haraken, 2014/10/09 04:24:02]

core_idl_files_with_modules_dependency ?

What happens if we write "an IDL file that should be in
core_idl_files_with_modules_dependency" in core_idl_files? Will it lead to a
compile error?

I'm fine with the approach of statically listing IDL files in GYP files, but we
should have a way to detect an error if a developer writes an IDL file in a
wrong target.

[tasak, 2014/10/10 07:52:24]

If we add an idl file with modules dependency to code_idl_files, we will see no
compile error and will see layout test regression (e.g. undefined XXX).

I think, presubmit check or bindings tests will help us to detect such errors.

[haraken, 2014/10/16 04:24:07]

I think we need to have a verification for this. Probably the IDL compiler can
do the verification because the IDL compiler knows what interface is depended by
what interfaces. You can do it in a follow-up.

+            'clipboard/DataTransferItem.idl',
+            'dom/URL.idl',
+            'frame/Navigator.idl',
+            'frame/Screen.idl',
+            'frame/Window.idl',
+            'html/HTMLInputElement.idl',
+            'html/HTMLMediaElement.idl',
+            'html/HTMLVideoElement.idl',
+            'inspector/InspectorFrontendHost.idl',
+            'workers/DedicatedWorkerGlobalScope.idl',
+            'workers/SharedWorker.idl',
+            'workers/SharedWorkerGlobalScope.idl',
+            'workers/WorkerGlobalScope.idl',
+            'workers/WorkerNavigator.idl',
+        ],
         # 'partial interface', target (right side of) 'implements', and
         # interfaces with static bindings (in bindings/core/v8/)
         'core_dependency_idl_files': [
             'animation/DocumentAnimation.idl',
             'animation/ElementAnimation.idl',
             'css/DocumentFontFaceSet.idl',
             'dom/ChildNode.idl',
             'dom/DocumentFullscreen.idl',
             'dom/ElementFullscreen.idl',
             'dom/GlobalEventHandlers.idl',
@@ skipping 2956 matching lines @@
         ],
         'core_testing_dictionary_idl_files': [
           'testing/InternalDictionary.idl',
         ],
         'webcore_testing_idl_files': [
           'testing/DictionaryTest.idl',
           'testing/GarbageCollectedScriptWrappable.idl',
           'testing/GCObservation.idl',
           'testing/InternalProfilers.idl',
           'testing/InternalSettings.idl',
-          'testing/Internals.idl',
           'testing/LayerRect.idl',
           'testing/LayerRectList.idl',
           'testing/PrivateScriptTest.idl',
           'testing/RefCountedScriptWrappable.idl',
           'testing/TypeConversions.idl',
         ],
+        # core defines, and modules updates with 'partial interface'

[haraken, 2014/10/09 04:24:02]

# testing IDL files that have partial interfaces in modules.

[tasak, 2014/10/10 07:52:24]

Done.

+        'webcore_testing_modules_dependency_idl_files': [
+          'testing/Internals.idl',
+        ],
         'webcore_testing_dependency_idl_files': [
           'testing/PartialPrivateScriptTest.idl',
         ],
         'generated_webcore_testing_idl_files': [
           '<(blink_core_output_dir)/InternalRuntimeFlags.idl',
           '<(blink_core_output_dir)/InternalSettingsGenerated.idl',
         ],
         'generated_core_testing_dictionary_files': [
           '<(blink_core_output_dir)/testing/InternalDictionary.cpp',
           '<(blink_core_output_dir)/testing/InternalDictionary.h',
@@ skipping 128 matching lines @@
             'rendering/shapes/BoxShapeTest.cpp',
             'rendering/style/OutlineValueTest.cpp',
             'testing/PrivateScriptTestTest.cpp',
             'streams/ReadableStreamTest.cpp',
             'testing/UnitTestHelpers.cpp',
             'testing/UnitTestHelpers.h',
             'xml/parser/SharedBufferReaderTest.cpp',
         ],
     }
 }