public/platform/WebRect.h - Issue 618373003: [bindings] partial interfaces should not violate componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebRect.h

Issue 618373003: [bindings] partial interfaces should not violate componentization (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added --target-component instead of --genearte-partial Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/platform/WebRect.h

diff --git a/public/platform/WebRect.h b/public/platform/WebRect.h

index 107c0b57e4b06698e4e0bbaab825253d18673e08..6c526b2bfe46a4a3dfd5914d216d3a9df5e3a31c 100644

--- a/public/platform/WebRect.h

+++ b/public/platform/WebRect.h

@@ -38,6 +38,9 @@

#else

#include <algorithm>

#include <cmath>

+// FIXME: ceil(x) macro defined in wtf/MathExtras.h causes compile error

+// when we have "std::ceil(x)". So use #undef ceil to avoid the error.

+#undef ceil

#include <ui/gfx/rect.h>

#endif