[bindings] partial interfaces should not violate componentization

Tools/Scripts/webkitpy/bindings/main.py

Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index cdbb6cdd3a0a1f204664073f6fe42d0ea0d8fc4d..6a1de1a680a6c026f5c6dc2341ae540a6cf1d2cf 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -45,6 +45,7 @@ from bindings.scripts.compute_interfaces_info_individual import compute_info_ind
 import bindings.scripts.compute_interfaces_info_overall
 from bindings.scripts.compute_interfaces_info_overall import compute_interfaces_info_overall, interfaces_info
 from bindings.scripts.idl_compiler import IdlCompilerDictionaryImpl, IdlCompilerV8
+from bindings.scripts.utilities import idl_filename_to_component
 
 
 PASS_MESSAGE = 'All tests PASS!'
@@ -231,6 +232,20 @@ def bindings_tests(output_directory, verbose):
             idl_compiler = IdlCompilerV8(output_dir,
                                          interfaces_info=interfaces_info,
                                          only_if_changed=True)
+            if component == 'core':
+                partial_interface_output_dir = os.path.join(output_directory,
+                                                            'modules')
+                if not os.path.exists(partial_interface_output_dir):
+                    os.makedirs(partial_interface_output_dir)
+                idl_partial_interface_compiler = IdlCompilerV8(
+                    partial_interface_output_dir,
+                    interfaces_info=interfaces_info,
+                    only_if_changed=True,
+                    target_component='modules')
+            else:
+                partial_interface_output_dir = None

[bashi, 2014/10/15 05:29:23]

Remove? It seems that you don't use |partial_interface_output_dir|.

[tasak, 2014/10/15 11:24:19]

Done.

+                idl_partial_interface_compiler = None

[bashi, 2014/10/15 05:29:23]

Question: Does this mean that we don't test partial interfaces in modules?

[tasak, 2014/10/15 11:24:19]

If partial interfaces are defined in modules and the original interfaces are
also defined in modules, the partial interfaces are merged into the original
interfaces.
So we don't see any partial interfaces. We can do this because of no
core/modules violation.

+
             dictionary_impl_compiler = IdlCompilerDictionaryImpl(
                 output_dir, interfaces_info=interfaces_info,
                 only_if_changed=True)
@@ -249,8 +264,12 @@ def bindings_tests(output_directory, verbose):
                 idl_basename = os.path.basename(idl_path)
                 idl_compiler.compile_file(idl_path)
                 definition_name, _ = os.path.splitext(idl_basename)
-                if (definition_name in interfaces_info and interfaces_info[definition_name]['is_dictionary']):
-                    dictionary_impl_compiler.compile_file(idl_path)
+                if definition_name in interfaces_info:
+                    interface_info = interfaces_info[definition_name]
+                    if interface_info['is_dictionary']:
+                        dictionary_impl_compiler.compile_file(idl_path)
+                    if component == 'core' and interface_info['partial_interface_dependencies_full_paths']:
+                        idl_partial_interface_compiler.compile_file(idl_path)
                 if verbose:
                     print 'Compiled: %s' % idl_path
     finally: